From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: "Kirill Yukhin" <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] engine: fix assert for multikey indexes
Date: Mon, 13 Jul 2020 15:17:47 +0300 [thread overview]
Message-ID: <1594642667.456715482@f474.i.mail.ru> (raw)
In-Reply-To: <20200713110438.ybqwjheccagy2uaj@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Hi!
>Понедельник, 13 июля 2020, 14:04 +03:00 от Kirill Yukhin <kyukhin@tarantool.org>:
>
>Hello,
>
>On 08 июл 00:19, Ilya Kosarev wrote:
>> Since 4273ec52e122d6d37c8deedf1bc10732a7e40c0e (box: introduce JSON
>> Indexes) we can create multikey index using array which might be the
>> first tuple field. It technically breaks assertion which implies that
>> first tuple field can't have offset in the tuple field map. Now the
>> assert us updated correspondingly. According test case is added.
>>
>> Closes #5132
>> ---
>> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5132-multiey-index-wrong-format-assert
>> Issue: https://github.com/tarantool/tarantool/issues/5132
>
>I've checked your patch into 2.3, 2.4 and master.
>
>--
>Regards, Kirill Yukhin
>>
>> @ChangeLog:
>> * Fix assert outdated due to multikey index arrival.
>
>In future, please mention issue in brackets: (gh-5132).
Right, sorry.
--
Ilya Kosarev
[-- Attachment #2: Type: text/html, Size: 1704 bytes --]
prev parent reply other threads:[~2020-07-13 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 21:19 Ilya Kosarev
2020-07-13 10:42 ` Aleksandr Lyapunov
2020-07-13 11:04 ` Kirill Yukhin
2020-07-13 12:17 ` Ilya Kosarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594642667.456715482@f474.i.mail.ru \
--to=i.kosarev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] engine: fix assert for multikey indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox