Re: [Tarantool-patches] [PATCH small 1/1] test: don't use not aligned size for mempool

["Sergey Ostanevich" <sergos@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]


LGTM.

I wonder how big is impact of all alignment activities? Can you consult with Mons to obtain a reference test?

Best regards,
Sergos 

Saturday, 20 June 2020, 21:01 +0300 from Vladislav Shpilevoy  <v.shpilevoy@tarantool.org>:
>Mempool expects aligned object size. Because it uses the free
>blocks to store metadata in them, in a struct mslab. Which needs
>alignment.
>
>Part of  https://github.com/tarantool/tarantool/issues/5063
>---
>Branch:  http://github.com/tarantool/small/tree/gerold103/tarantool/gh-5063-not-aligned-test
>Issue:  https://github.com/tarantool/tarantool/issues/5063
>
> test/mempool.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/test/mempool.c b/test/mempool.c
>index 298ba17..65eabaf 100644
>--- a/test/mempool.c
>+++ b/test/mempool.c
>@@ -1,3 +1,4 @@
>+#include "trivia/util.h"
> #include <small/mempool.h>
> #include <small/quota.h>
> #include <stdio.h>
>@@ -121,6 +122,12 @@ int main()
> 	objsize = rand() % OBJSIZE_MAX;
> 	if (objsize < OBJSIZE_MIN)
> 		objsize = OBJSIZE_MIN;
>+	/*
>+	 * Mempool does not work with not aligned sizes. Because
>+	 * it utilizes the unused blocks for storing internal
>+	 * info, which needs alignment.
>+	 */
>+	objsize = small_align(objsize, alignof(uint64_t));
> 
> 	quota_init(&quota, UINT_MAX);
> 
>-- 
>2.21.1 (Apple Git-122.3)
>

[-- Attachment #2: Type: text/html, Size: 4213 bytes --]