Re: [Tarantool-patches] [PATCH v1] gitlab-ci: integration testting connectors

["Oleg Piskunov" <o.piskunov@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]


Sergey,
 
Thanks for the review.
I comented your suggestion below and applied changes into branch
https://github.com/tarantool/tarantool/tree/opiskunov/gh-4856-integration-test-connectors
I don’t send new patch cause, as we agreed, need to use test-run for testing connectors. 
  
>Четверг, 21 мая 2020, 19:10 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>Hi, Oleg
>
>Thanks for the patch! See my coments inline.
>
>>  # Release
>>  
>>  build_debian:
>> -       cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
>> +       cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}
>
>Why do we need ENABLE_WERROR here?
I didn’t add ENABLE_WERROR here — it comes from release build. I have added DENABLE_DIST=ON, and we already discussed it in «vshard» thread.
>> +# Integration testing
>> +
>> +test_connector_python_asynctnt: build_debian
>> +       make install
>
>Let's create a separate target for tarantool installation and add it to
>dependence. Same for targets below.
Sure. will do.
>The same question as for vshard - why should we test tarantool against
>unreleased versions of connectors?
I have changed connectors version to the latest released:
 
 java ( https://github.com/tarantool/tarantool-java ) — tag: connector-1.9.4
 python ( https://github.com/tarantool/tarantool-python ) — tag: 0.6.6
 python ( https://github.com/igorcoding/asynctnt ) — tag: v1.2
 golang ( https://github.com/tarantool/go-tarantool ) — tag: v1.5
 golang ( https://github.com/viciious/go-tarantool ) — tag: v1.0
 php ( https://github.com/tarantool/tarantool-php ) — branch: php7-v2
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 3386 bytes --]