From: "Oleg Piskunov" <o.piskunov@tarantool.org>
To: "Sergey Bronnikov" <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
"Alexander Turenko" <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup temporary perf images
Date: Thu, 21 May 2020 10:09:04 +0300 [thread overview]
Message-ID: <1590044944.522866659@f148.i.mail.ru> (raw)
In-Reply-To: <20200520083023.GC1400@pony.bronevichok.ru>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Sergey, thanks for review.
The reason is that each temporary docker image is about 5 GB and we don’t have space to keep it localy.
I will update commit message.
>Среда, 20 мая 2020, 11:31 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
>
>Hi, Oleg!
>
>generally LGTM, but see my question regarding commit message.
>
>On 03:36 Wed 20 May , Oleg Piskunov wrote:
>>
>>
>> - add cleanup after perf docker
>> image preparation (perf_bootstrap job).
>> - cleanup perf docker images on execution hosts
>> after perf testing (cleanup stage).
>>
>> Closes #5003
>There is a best practice to explain 'what' and 'why' in a commit message
>body. It is unclear why we should cleanup these images and cannot reuse
>existed images.
>
><snipped>
--
Oleg Piskunov
[-- Attachment #2: Type: text/html, Size: 1401 bytes --]
next prev parent reply other threads:[~2020-05-21 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 0:36 Oleg Piskunov
2020-05-20 8:30 ` Sergey Bronnikov
2020-05-21 7:09 ` Oleg Piskunov [this message]
2020-05-20 16:44 ` Alexander V. Tikhonov
2020-05-21 7:53 ` Oleg Piskunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590044944.522866659@f148.i.mail.ru \
--to=o.piskunov@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup temporary perf images' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox