From: "Oleg Piskunov" <o.piskunov@tarantool.org>
To: "Sergey Bronnikov" <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
"Alexander Turenko" <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: integration testing vshard
Date: Mon, 18 May 2020 16:05:59 +0300 [thread overview]
Message-ID: <1589807159.937725626@f123.i.mail.ru> (raw)
In-Reply-To: <20200518090010.GA20053@pony.bronevichok.ru>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
Sergey, thanks for review. Below my comments.
>Понедельник, 18 мая 2020, 12:00 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
>
>Hi, Oleg
>
>just a curious - why you didn't add vshard tests to test/ dir in tarantool
>to be able to run them using usual test-run.py?
The reason that I testing vshard module (installation and testing) using vshard repo and as described in vshard module instruction. Any way, it’s no improvment to do it as you suggested.
--
Oleg Piskunov
[-- Attachment #2: Type: text/html, Size: 991 bytes --]
prev parent reply other threads:[~2020-05-18 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 7:35 Oleg Piskunov
2020-05-17 12:31 ` Alexander V. Tikhonov
2020-05-18 12:46 ` Oleg Piskunov
2020-05-18 9:00 ` Sergey Bronnikov
2020-05-18 13:05 ` Oleg Piskunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589807159.937725626@f123.i.mail.ru \
--to=o.piskunov@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: integration testing vshard' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox