Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Oleg Piskunov" <o.piskunov@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs
Date: Thu, 14 May 2020 15:03:48 +0300	[thread overview]
Message-ID: <1589457828.923989643@f301.i.mail.ru> (raw)
In-Reply-To: <2ad8677044f4a2eac3ec7ae3479dbebe09ea3f15.1589452096.git.avtikhon@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]


LGTM

  
>Четверг, 14 мая 2020, 13:29 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
> 
>Release branches should be regularly run using gitlab-ci pipeline
>schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
>It will help to detect flaky issues. But there is no need to rerun
>too long running performance testing, to block it in schedules the
>option 'schedules' in 'except:' field was set.
>
>Part of #4974
>---
>
>Github:  https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
>Issue:  https://github.com/tarantool/tarantool/issues/4974
>
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index c7f58b98d..256b368c4 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -32,6 +32,8 @@ variables:
>   only:
>     - master
>     - /^.*-perf$/
>+ except:
>+ - schedules
>   variables: &perf_vars_definition
>     IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
>     IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
>--
>2.17.1
>  
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 2094 bytes --]

  parent reply	other threads:[~2020-05-14 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 10:29 Alexander V. Tikhonov
2020-05-14 10:43 ` Sergey Bronnikov
2020-05-14 12:03 ` Oleg Piskunov [this message]
2020-05-15 14:51 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589457828.923989643@f301.i.mail.ru \
    --to=o.piskunov@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox