From: "Георгий Кириченко" <georgy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: vdavydov.dev@gmail.com, tarantool-patches@freelists.org,
kostja@tarantool.org
Subject: Re: [PATCH v3 1/4] third-party: add decNumber library
Date: Wed, 05 Jun 2019 11:04:45 +0300 [thread overview]
Message-ID: <1588797.LHELRbcstj@localhost> (raw)
In-Reply-To: <9eae92dc51cce762023fa77670d3b9183f571645.1559663794.git.sergepetrenko@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
LGTM
On Tuesday, June 4, 2019 7:04:16 PM MSK Serge Petrenko wrote:
> We will use it for decimal implementation in tarantool
>
> Part of #692
> ---
> .gitmodules | 3 +++
> third_party/decNumber | 1 +
> 2 files changed, 4 insertions(+)
> create mode 160000 third_party/decNumber
>
> diff --git a/.gitmodules b/.gitmodules
> index e3aa7d79e..9f52c3fc1 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -31,3 +31,6 @@
> path = third_party/luarocks
> url = https://github.com/tarantool/luarocks.git
> branch = tarantool-1.7
> +[submodule "third_party/decNumber"]
> + path = third_party/decNumber
> + url = https://github.com/tarantool/decNumber.git
> diff --git a/third_party/decNumber b/third_party/decNumber
> new file mode 160000
> index 000000000..04e31ac65
> --- /dev/null
> +++ b/third_party/decNumber
> @@ -0,0 +1 @@
> +Subproject commit 04e31ac65efbfb426c7fc299e736ea4e591b41a9
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-05 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:04 [PATCH v3 0/4] Introduce decimal type to tarantool core Serge Petrenko
2019-06-04 16:04 ` [PATCH v3 1/4] third-party: add decNumber library Serge Petrenko
2019-06-05 8:04 ` Георгий Кириченко [this message]
2019-06-04 16:04 ` [PATCH v3 2/4] lib/core: introduce decimal type to tarantool Serge Petrenko
2019-06-05 8:11 ` Георгий Кириченко
2019-06-05 10:03 ` Serge Petrenko
2019-06-05 12:19 ` Vladimir Davydov
2019-06-11 16:14 ` [tarantool-patches] " Serge Petrenko
2019-06-04 16:04 ` [PATCH v3 3/4] lib: update msgpuck library Serge Petrenko
2019-06-04 16:04 ` [PATCH v3 4/4] decimal: add MessagePack encoding/decoding support Serge Petrenko
2019-06-05 8:20 ` Георгий Кириченко
2019-06-05 12:40 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588797.LHELRbcstj@localhost \
--to=georgy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v3 1/4] third-party: add decNumber library' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox