Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Олег Пискунов" <o.piskunov@corp.mail.ru>
To: tarantool-patches@dev.tarantool.org
Cc: "Oleg Piskunov" <o.piskunov@tarantool.org>
Subject: [Tarantool-patches] [PATCH v1] bench-run: refactoring perf docker image
Date: Tue, 21 Apr 2020 15:39:15 +0300	[thread overview]
Message-ID: <1587472755.685972468@f558.i.mail.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 2251 bytes --]



Fix docker image for perf testing:
- Disable caching for second stage docker file creation
  for correct Tarantool and bench-run version checkout.
- bench-run repository creation moved from dockerfile
  of the first stage to the second.
 
Close #4870
---
 
Github: https://github.com/tarantool/bench-run/tree/opiskunov/gh-4870-refactor-docker-perf
Issue: https://github.com/tarantool/tarantool/issues/4870
 
 dockerfiles/ubuntu_benchs | 3 ---
 dockerfiles/ubuntu_tnt    | 3 +++
 targets.mk                | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
 
diff --git a/dockerfiles/ubuntu_benchs b/dockerfiles/ubuntu_benchs
index fd9acb4..f5389f4 100644
--- a/dockerfiles/ubuntu_benchs
+++ b/dockerfiles/ubuntu_benchs
@@ -70,6 +70,3 @@ WORKDIR /opt/linkbench
 RUN luarocks install \
     https://raw.githubusercontent.com/tarantool/gperftools/master/rockspecs/gperftools-scm-1.rockspec \
     --local >build.log 2>&1 || ( cat build.log && false )
-
-# benchmarks runners
-RUN git clone https://github.com/tarantool/bench-run.git /opt/bench-run
diff --git a/dockerfiles/ubuntu_tnt b/dockerfiles/ubuntu_tnt
index 361e9d6..1704508 100644
--- a/dockerfiles/ubuntu_tnt
+++ b/dockerfiles/ubuntu_tnt
@@ -8,6 +8,9 @@ RUN ( cmake . -DENABLE_DIST=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo >build.log 2>&1
     && make -j >>build.log 2>&1 && make install >>build.log 2>&1 ) || \
     ( cat build.log && false )
 
+# benchmarks runners
+RUN git clone https://github.com/tarantool/bench-run.git /opt/bench-run
+
 # cbench
 RUN git clone https://github.com/tarantool/cbench.git /opt/cbench
 WORKDIR /opt/cbench
diff --git a/targets.mk b/targets.mk
index 6cf36b6..581b722 100644
--- a/targets.mk
+++ b/targets.mk
@@ -21,7 +21,7 @@ prepare:
        docker push ${IMAGE_PERF}
        # build Tarantool and benchmarks with depends on Tarantool sources
        ${DOCKERFILE_BUILD} --build-arg image_from=${IMAGE_PERF} \
-               -t ${IMAGE_PERF_BUILT} -f bench-run/dockerfiles/ubuntu_tnt .
+               -t ${IMAGE_PERF_BUILT} --no-cache -f bench-run/dockerfiles/ubuntu_tnt .
        docker push ${IMAGE_PERF_BUILT}
 
 # #####################################################
--
1.8.3.1
 

[-- Attachment #2: Type: text/html, Size: 2923 bytes --]

             reply	other threads:[~2020-04-21 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 12:39 Олег Пискунов [this message]
2020-04-21 20:06 ` Alexander Tikhonov
2020-04-30  9:50 ` Sergey Bronnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587472755.685972468@f558.i.mail.ru \
    --to=o.piskunov@corp.mail.ru \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] bench-run: refactoring perf docker image' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox