From: "Alexander Tikhonov" <avtikhon@tarantool.org>
To: "Oleg Piskunov" <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
Date: Wed, 15 Apr 2020 16:34:00 +0300 [thread overview]
Message-ID: <1586957640.889947249@f347.i.mail.ru> (raw)
In-Reply-To: <1586957095.870829578@f548.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]
Hi Oleg, thanks for the review, mistakenly missed to remove the middle changes for the future release — corrected and patch resent.
>Среда, 15 апреля 2020, 16:24 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:
>
>Hi,
>
>Sasha, thanks for the patch.
>
>As I can see you are not only remove ubuntu_19_04 and ubuntu_19_04_deploy, but
>also adding ubuntu_20_04_deploy. Which is not related to commit message and issue.
>
>>Среда, 15 апреля 2020, 9:07 +03:00 от Alexander V. Tikhonov < avtikhon@tarantool.org >:
>>
>>Removed Ubuntu 19.04 Disco from testing which is EOL.
>>
>>Close #4896
>>---
>>
>>Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
>>Issue: https://github.com/tarantool/tarantool/issues/4896
>>
>> .gitlab-ci.yml | 14 ++++----------
>> .travis.yml | 3 ---
>> 2 files changed, 4 insertions(+), 13 deletions(-)
>>
>>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>index cd710027f..9c996fd7b 100644
>>--- a/.gitlab-ci.yml
>>+++ b/.gitlab-ci.yml
>>@@ -323,12 +323,6 @@ ubuntu_18_04:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>>-ubuntu_19_04:
>>- <<: *pack_definition
>>- variables:
>>- OS: 'ubuntu'
>>- DIST: 'disco'
>>-
>> ubuntu_19_10:
>> <<: *pack_definition
>> variables:
>>@@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>>-ubuntu_19_04_deploy:
>>+ubuntu_19_10_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>>- DIST: 'disco'
>>+ DIST: 'eoan'
>>
>>-ubuntu_19_10_deploy:
>>+ubuntu_20_04_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>>- DIST: 'eoan'
>>+ DIST: 'focal'
>>
>> debian_8_deploy:
>> <<: *deploy_definition
>>diff --git a/.travis.yml b/.travis.yml
>>index c63ab3ebd..41540fb79 100644
>>--- a/.travis.yml
>>+++ b/.travis.yml
>>@@ -67,9 +67,6 @@ jobs:
>> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>> env: OS=ubuntu DIST=bionic
>> if: branch = "master"
>>- - name: "Ubuntu Disco (19.04) build + deploy DEB"
>>- env: OS=ubuntu DIST=disco
>>- if: branch = "master"
>> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>> env: OS=ubuntu DIST=eoan
>> if: branch = "master"
>>--
>>2.17.1
>>
>
>
>--
>Oleg Piskunov
>
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 4574 bytes --]
prev parent reply other threads:[~2020-04-15 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 6:07 Alexander V. Tikhonov
2020-04-15 8:25 ` Sergey Bronnikov
2020-04-15 9:05 ` Alexander Tikhonov
2020-04-15 10:47 ` Sergey Bronnikov
2020-04-15 13:24 ` Oleg Piskunov
2020-04-15 13:34 ` Alexander Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586957640.889947249@f347.i.mail.ru \
--to=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox