[Tarantool-patches] [PATCH v1] Enable branch coverage in lcov

[Tarantool-patches] [PATCH v1] Enable branch coverage in lcov

[Sergey Bronnikov]

By default lcov collects line coverage only. It would be useful to
collect function and branch coverage too.

Closes #4888
---

GH branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage
GH issue: https://github.com/tarantool/tarantool/issues/4891
Example on Coveralls (column "Run details"): https://coveralls.io/builds/30058630

 .travis.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.travis.mk b/.travis.mk
index f709a18b6..a92efbcd6 100644
--- a/.travis.mk
+++ b/.travis.mk
@@ -96,9 +96,10 @@ build_coverage_debian:
 test_coverage_debian_no_deps: build_coverage_debian
 	# Enable --long tests for coverage
 	cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS) --long
-	lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp
+	lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp \
+		--rc lcov_branch_coverage=1 --rc lcov_function_coverage=1
 	lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \
-		--output-file coverage.info
+		--rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 --output-file coverage.info
 	lcov --list coverage.info
 	@if [ -n "$(COVERALLS_TOKEN)" ]; then \
 		echo "Exporting code coverage information to coveralls.io"; \
-- 
2.23.0


-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v1] Enable branch coverage in lcov

[Oleg Piskunov]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]


LGTM.

minor below: 
>Вторник, 14 апреля 2020, 12:55 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>By default lcov collects line coverage only. It would be useful to
>collect function and branch coverage too.
>
>Closes #4888
>---
>
>GH branch:  https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage
>GH issue:  https://github.com/tarantool/tarantool/issues/4891
issue 4888
>
>Example on Coveralls (column "Run details"):  https://coveralls.io/builds/30058630
>
> .travis.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/.travis.mk b/.travis.mk
>index f709a18b6..a92efbcd6 100644
>--- a/.travis.mk
>+++ b/.travis.mk
>@@ -96,9 +96,10 @@ build_coverage_debian:
> test_coverage_debian_no_deps: build_coverage_debian
>  # Enable --long tests for coverage
>  cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS) --long
>- lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp
>+ lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp \
>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1
>  lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \
>- --output-file coverage.info
>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 --output-file coverage.info
>  lcov --list coverage.info
>  @if [ -n "$(COVERALLS_TOKEN)" ]; then \
>  echo "Exporting code coverage information to coveralls.io"; \
>--
>2.23.0
>
>
>--
>sergeyb@ 
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 2541 bytes --]

Re: [Tarantool-patches] [PATCH v1] Enable branch coverage in lcov

[Alexander Tikhonov]

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]


Hi Sergey, thanks for the patch, LGTM.

  
>Вторник, 14 апреля 2020, 12:55 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>By default lcov collects line coverage only. It would be useful to
>collect function and branch coverage too.
>
>Closes #4888
>---
>
>GH branch:  https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage
>GH issue:  https://github.com/tarantool/tarantool/issues/4891
>Example on Coveralls (column "Run details"):  https://coveralls.io/builds/30058630
>
> .travis.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/.travis.mk b/.travis.mk
>index f709a18b6..a92efbcd6 100644
>--- a/.travis.mk
>+++ b/.travis.mk
>@@ -96,9 +96,10 @@ build_coverage_debian:
> test_coverage_debian_no_deps: build_coverage_debian
>  # Enable --long tests for coverage
>  cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS) --long
>- lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp
>+ lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp \
>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1
>  lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \
>- --output-file coverage.info
>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 --output-file coverage.info
>  lcov --list coverage.info
>  @if [ -n "$(COVERALLS_TOKEN)" ]; then \
>  echo "Exporting code coverage information to coveralls.io"; \
>--
>2.23.0
>
>
>--
>sergeyb@ 
 
 
--
Alexander Tikhonov
 

[-- Attachment #2: Type: text/html, Size: 2367 bytes --]

Re: [Tarantool-patches] [PATCH v1] Enable branch coverage in lcov

[Kirill Yukhin]

Hello,

On 14 апр 12:55, Sergey Bronnikov wrote:
> By default lcov collects line coverage only. It would be useful to
> collect function and branch coverage too.
> 
> Closes #4888
> ---
> 
> GH branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage
> GH issue: https://github.com/tarantool/tarantool/issues/4891
> Example on Coveralls (column "Run details"): https://coveralls.io/builds/30058630

I've checked your patch into master.

--
Regards, Kirill Yukhin