[Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile

[Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile

[Alexander V. Tikhonov]

gitlab-ci: set static docker build release testing

Found that static build based on Dockerfile used external link
and missed that it was removed, like it was in #4830. To avoid
of the same issues the cache for building the Dockerfile was
disabled with '--no-cache' option at docker build command.
    
Returned the static build based on Dockerfile to gitlab-ci release branches
testing after the issues with missed openssl version fixed at PR #4831.
  
Follow up #4831
Follow up #4830

Github: https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4830
Issue: https://github.com/tarantool/tarantool/issues/4831

Alexander V. Tikhonov (2):
  build: disable cache for static build Dockerfile
  gitlab-ci: set static docker build release testing

 .gitlab-ci.yml | 4 +++-
 .travis.mk     | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.17.1

[Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile

[Alexander V. Tikhonov]

Found that static build based on Dockerfile used external link
and missed that it was removed, like it was in #4830. To avoid
of the same issues the cache for building the Dockerfile was
disabled with '--no-cache' option at docker build command.

Follow up #4830
---
 .travis.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.mk b/.travis.mk
index f709a18b6..54a4d5d91 100644
--- a/.travis.mk
+++ b/.travis.mk
@@ -143,7 +143,7 @@ test_static_build: deps_debian_static
 	CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
 
 test_static_docker_build:
-	docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
+	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
 
 #######
 # OSX #
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile

[Sergey Bronnikov]

Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Found that static build based on Dockerfile used external link
> and missed that it was removed, like it was in #4830. To avoid
> of the same issues the cache for building the Dockerfile was
> disabled with '--no-cache' option at docker build command.
> 
> Follow up #4830
> ---
>  .travis.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.mk b/.travis.mk
> index f709a18b6..54a4d5d91 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -143,7 +143,7 @@ test_static_build: deps_debian_static
>  	CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
>  
>  test_static_docker_build:
> -	docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
> +	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>  
>  #######
>  # OSX #
> -- 
> 2.17.1
> 

-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile

[Oleg Piskunov]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]



LGTM
  
>Вторник, 14 апреля 2020, 11:28 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>Thanks for the patch!
>
>LGTM
>
>On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
>> Found that static build based on Dockerfile used external link
>> and missed that it was removed, like it was in #4830. To avoid
>> of the same issues the cache for building the Dockerfile was
>> disabled with '--no-cache' option at docker build command.
>>
>> Follow up #4830
>> ---
>> .travis.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.travis.mk b/.travis.mk
>> index f709a18b6..54a4d5d91 100644
>> --- a/.travis.mk
>> +++ b/.travis.mk
>> @@ -143,7 +143,7 @@ test_static_build: deps_debian_static
>> CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
>>
>> test_static_docker_build:
>> - docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>> + docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>>
>> #######
>> # OSX #
>> --
>> 2.17.1
>>
>--
>sergeyb@ 
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 1726 bytes --]

[Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing

[Alexander V. Tikhonov]

Returned the static build based on Dockerfile to gitlab-ci release branches
testing after the issues with missed openssl version fixed at PR #4831.

Follow up #4831
---
 .gitlab-ci.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd710027f..f0d5d9b7c 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -454,6 +454,8 @@ static_build:
 
 static_docker_build:
   <<: *release_only_definition
-  <<: *pack_test_definition
+  stage: test
+  tags:
+    - deploy_test
   script:
     - ${GITLAB_MAKE} test_static_docker_build
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing

[Sergey Bronnikov]

Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Returned the static build based on Dockerfile to gitlab-ci release branches
> testing after the issues with missed openssl version fixed at PR #4831.
> 
> Follow up #4831
> ---
>  .gitlab-ci.yml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..f0d5d9b7c 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -454,6 +454,8 @@ static_build:
>  
>  static_docker_build:
>    <<: *release_only_definition
> -  <<: *pack_test_definition
> +  stage: test
> +  tags:
> +    - deploy_test
>    script:
>      - ${GITLAB_MAKE} test_static_docker_build
> -- 
> 2.17.1
> 

-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing

[Oleg Piskunov]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]



LGTM
  
>Вторник, 14 апреля 2020, 11:28 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>Thanks for the patch!
>
>LGTM
>
>On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
>> Returned the static build based on Dockerfile to gitlab-ci release branches
>> testing after the issues with missed openssl version fixed at PR #4831.
>>
>> Follow up #4831
>> ---
>> .gitlab-ci.yml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index cd710027f..f0d5d9b7c 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -454,6 +454,8 @@ static_build:
>>
>> static_docker_build:
>> <<: *release_only_definition
>> - <<: *pack_test_definition
>> + stage: test
>> + tags:
>> + - deploy_test
>> script:
>> - ${GITLAB_MAKE} test_static_docker_build
>> --
>> 2.17.1
>>
>--
>sergeyb@ 
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 1520 bytes --]

Re: [Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile

[Kirill Yukhin]

Hello,

On 07 апр 17:03, Alexander V. Tikhonov wrote:
> gitlab-ci: set static docker build release testing
> 
> Found that static build based on Dockerfile used external link
> and missed that it was removed, like it was in #4830. To avoid
> of the same issues the cache for building the Dockerfile was
> disabled with '--no-cache' option at docker build command.
>     
> Returned the static build based on Dockerfile to gitlab-ci release branches
> testing after the issues with missed openssl version fixed at PR #4831.
>   
> Follow up #4831
> Follow up #4830
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4830
> Issue: https://github.com/tarantool/tarantool/issues/4831

I've checked your patchset into 1.10, 2.2, 2.3 and master.

--
Regards, Kirill Yukhin