From: "Oleg Piskunov" <o.piskunov@tarantool.org> To: "Sergey Bronnikov" <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1] Enable branch coverage in lcov Date: Tue, 14 Apr 2020 13:27:03 +0300 [thread overview] Message-ID: <1586860023.125012914@f506.i.mail.ru> (raw) In-Reply-To: <21f37877a919d3cea6ad93965d4ce4fe6b4d3102.1586857868.git.sergeyb@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 1553 bytes --] LGTM. minor below: >Вторник, 14 апреля 2020, 12:55 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>: > >By default lcov collects line coverage only. It would be useful to >collect function and branch coverage too. > >Closes #4888 >--- > >GH branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage >GH issue: https://github.com/tarantool/tarantool/issues/4891 issue 4888 > >Example on Coveralls (column "Run details"): https://coveralls.io/builds/30058630 > > .travis.mk | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/.travis.mk b/.travis.mk >index f709a18b6..a92efbcd6 100644 >--- a/.travis.mk >+++ b/.travis.mk >@@ -96,9 +96,10 @@ build_coverage_debian: > test_coverage_debian_no_deps: build_coverage_debian > # Enable --long tests for coverage > cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS) --long >- lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp >+ lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp \ >+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 > lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \ >- --output-file coverage.info >+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 --output-file coverage.info > lcov --list coverage.info > @if [ -n "$(COVERALLS_TOKEN)" ]; then \ > echo "Exporting code coverage information to coveralls.io"; \ >-- >2.23.0 > > >-- >sergeyb@ -- Oleg Piskunov [-- Attachment #2: Type: text/html, Size: 2541 bytes --]
next prev parent reply other threads:[~2020-04-14 10:27 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-14 9:55 Sergey Bronnikov 2020-04-14 10:27 ` Oleg Piskunov [this message] 2020-04-15 8:49 ` Alexander Tikhonov 2020-04-15 11:17 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1586860023.125012914@f506.i.mail.ru \ --to=o.piskunov@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] Enable branch coverage in lcov' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox