Re: [Tarantool-patches] [PATCH v1 0/2] gitlab-ci: add Catalina OSX 10.15

["Alexander Tikhonov" <avtikhon@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1892 bytes --]


Hi Sergey, thanks for the review, please check my comments below.

  
>Пятница, 10 апреля 2020, 17:34 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>Hi,
>
>Sasha, thanks for the patch. See my comment below.
>
>On 11:40 Thu 09 Apr , Alexander V. Tikhonov wrote:
>> gitlab-ci: add Catalina OSX 10.15
>>
>> Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
>> due to decided to have only 2 last major releases, for now it is
>> 10.14 and 10.15 OSX versions. Also changed the commit job for branches
>> from 10.14 to 10.15 OSX version.
>>
>> Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
>> otherwise it doesn't have the path to brew installed packages.
>
>PATH can be adjusted in runtime with 'export' call and by using
>user-specific $HOME/.profile and reloading it to current environemnt.
>What are the reasons to touch system-wide file?
Unfortunately we can’t be sure what path is really needed, that is why I used to call
/etc/profile file for PATH setup, by the internal call to special tool ‘/usr/libexec/path_helper’
which can detect needed paths itself. Anyway, may be this way is not clear and better
to use here the script that is needed, that is why I’ve changed the call of /etc/profile to
/usr/libexec/path_helper.
>> Formula tntpython2.rb consist of the packages which download target host
>> does not have valid SSL certificate, disabled curl SSL check for it,
>> also the same issue resolved for pip packages.
>>
>> Github:  https://github.com/tarantool/tarantool/tree/avtikhon/osx_15_catalina-full-ci
>>
>> Alexander V. Tikhonov (2):
>> build: disable at OSX curl SSL
>> gitlab-ci: add Catalina OSX 10.15
>>
>> .gitlab-ci.yml | 11 ++++++-----
>> .travis.mk | 15 +++++++++++++--
>> 2 files changed, 19 insertions(+), 7 deletions(-)
>>
>> --
>> 2.17.1
>>
>
>--
>sergeyb@ 
 
 
--
Alexander Tikhonov
 

[-- Attachment #2: Type: text/html, Size: 2808 bytes --]