Re: [Tarantool-patches] [PATCH v2] test: fix OSX host setup

["Alexander Tikhonov" <avtikhon@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]


Sergey, thanks a lot for the review, I’ve really missed that forgot to mention about the source of the tapped formula. I’ve added the comment about the way I’ve created it.

  
>Среда, 25 марта 2020, 10:59 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> 
>On 21:09 Mon 23 Mar , Alexander V. Tikhonov wrote:
>> Fixed OSX host setup for Tarantool build:
>> - set brew installation from Homebrew repository instructions;
>> - set in use Python 2 latest commit from tapped local formula,
>> since Python 2 is EOL, also removed extra pip installation with
>> get-pip script, because tapped formula installs pip itself;
>> - added upgrade packages call to avoid of fails on already
>> installed packages, but with previous version.
>>
>> Fixed OSX host setup for Tarantool test:
>> - set maximum processes limit value to 2500 for testing process;
>> - set 'var' directory for test-run tool to the shorter path name
>> to avoid of issues with long names;
>Looks good to me. One note: I suspect python brew file was copied
>from somewhere. It would be better to specify resource. 
 
 
--
Alexander Tikhonov
 

[-- Attachment #2: Type: text/html, Size: 1663 bytes --]