Re: [Tarantool-patches] [PATCH v2 2/2] test: rename test files

["Alexander Tikhonov" <avtikhon@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 3995 bytes --]



Igor, thanks for your review, I’ve made all the changes you suggested.
  
>Пятница, 28 февраля 2020, 21:42 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Sasha,
>
>Thanks for the patch. I left some comments below, please consider them.
>
>On 27.02.20, Alexander V. Tikhonov wrote:
>> Renamed test files in the following way:
>> <repo>-<number>-<comment>.test.lua
>> where "external repo" is github repository:
>
>Typo: s/external repo/<repo>/.
Done.
>
>> gh - tarantool/tarantool
>> lj - luajit/luajit
>
>Typo: s/luajit/LuaJIT/g.
Done.
>> or - openresty/lua-resty-core
>
>Typo: s/lua-resty-core/luajit2/.
Done.
>>
>> Close #4655
>> ---
>> test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} | 0
>> ...ording.test.lua => gh-4476-fix-string-find-recording.test.lua} | 0
>> ...mm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} | 0
>> ...JIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} | 0
>> ...LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} | 0
>> test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} | 0
>> ...LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} | 0
>> 7 files changed, 0 insertions(+), 0 deletions(-)
>> rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (100%)
>> rename test/{fix_string_find_recording.test.lua => gh-4476-fix-string-find-recording.test.lua} (100%)
>> rename test/{pairsmm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} (100%)
>> rename test/{table_chain_bug_LuaJIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} (100%)
>> rename test/{fold_bug_LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} (100%)
>> rename test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} (100%)
>> rename test/{fold_bug_LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} (100%)
>>
>> diff --git a/test/gh.test.lua b/test/gh-3196-incorrect-string-length.test.lua
>> similarity index 100%
>> rename from test/gh.test.lua
>> rename to test/gh-3196-incorrect-string-length.test.lua
>> diff --git a/test/fix_string_find_recording.test.lua b/test/gh-4476-fix-string-find-recording.test.lua
>> similarity index 100%
>> rename from test/fix_string_find_recording.test.lua
>> rename to test/gh-4476-fix-string-find-recording.test.lua
>
>I propose test/gh-4476-fix-string-find-recording.test.lua.
Seems the same.
>> diff --git a/test/pairsmm_tarantool_4560.test.lua b/test/gh-4560-pairsmm-is-set.test.lua
>> similarity index 100%
>> rename from test/pairsmm_tarantool_4560.test.lua
>> rename to test/gh-4560-pairsmm-is-set.test.lua
>
>Please rebase your changes on the stable branch, since this test has
>been removed in a9eebfa.
Done - test removed.
>> diff --git a/test/table_chain_bug_LuaJIT_494.test.lua b/test/lj-494-table-chain-infinite-loop.test.lua
>> similarity index 100%
>> rename from test/table_chain_bug_LuaJIT_494.test.lua
>> rename to test/lj-494-table-chain-infinite-loop.test.lua
>> diff --git a/test/fold_bug_LuaJIT_505.test.lua b/test/lj-505-fold-icorrect-behavior.test.lua
>> similarity index 100%
>> rename from test/fold_bug_LuaJIT_505.test.lua
>> rename to test/lj-505-fold-icorrect-behavior.test.lua
>
>I propose test/lj-505-fold-no-strref-for-ptrdiff.test.lua.
Done.
>> diff --git a/test/unsink_64_kptr.test.lua b/test/or-232-unsink-64-kptr.test.lua
>> similarity index 100%
>> rename from test/unsink_64_kptr.test.lua
>> rename to test/or-232-unsink-64-kptr.test.lua
>> diff --git a/test/fold_bug_LuaJIT_524.test.lua b/test/or-524-fold-icorrect-behavior.test.lua
>> similarity index 100%
>> rename from test/fold_bug_LuaJIT_524.test.lua
>> rename to test/or-524-fold-icorrect-behavior.test.lua
>
>The original issue comes from LuaJIT/LuaJIT queue, so the prefix should
>be 'lj-' instead of 'or-'. Also there is a typo: s/icorrect/incorrect/.
>
>I propose test/lj-524-fold-conv-respect-src-irt.test.lua.
Done.
>> --
>> 2.17.1
>>
>
>--
>Best regards,
>IM 
 
 
--
Alexander Tikhonov
 

[-- Attachment #2: Type: text/html, Size: 6170 bytes --]