From: "Oleg Piskunov" <o.piskunov@tarantool.org>
To: "Sergey Bronnikov" <sergeyb@tarantool.org>,
"Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] Divide box/ddl.test.lua test
Date: Wed, 18 Mar 2020 00:46:54 +0300 [thread overview]
Message-ID: <1584481614.244430679@f335.i.mail.ru> (raw)
In-Reply-To: <20200317150048.GA13545@pony.bronevichok.ru>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
Hi,
Agreed with everything except one place:
>> diff --git a/test/box/gh-3290-ddl_collation_deleted.test.lua b/test/box/gh-3290-ddl_collation_deleted.test.lua
>> new file mode 100644
>> index 000000000..f36838e7a
>> --- /dev/null
>> +++ b/test/box/gh-3290-ddl_collation_deleted.test.lua
>> @@ -0,0 +1,10 @@
>> +env = require('test_run')
>> +test_run = env.new()
>
>unused variables
>
>> +--
>> +-- gh-3290: expose ICU into Lua. It uses built-in collations, that
>> +-- must work even if a collation is deleted from _collation.
>> +--
>> +t = box.space._collation:delete{1}
>> +utf8.cmp('abc', 'def')
>> +box.space._collation:replace(t)
>
>missed cleanup
>
In this place cleanup not needed.
The last line restores the original state or «cleanup»
>--
>sergeyb@
--
Oleg Piskunov
[-- Attachment #2: Type: text/html, Size: 1345 bytes --]
next prev parent reply other threads:[~2020-03-17 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 16:19 Alexander V. Tikhonov
2020-03-17 15:00 ` Sergey Bronnikov
2020-03-17 21:46 ` Oleg Piskunov [this message]
2020-03-18 10:01 ` Alexander Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584481614.244430679@f335.i.mail.ru \
--to=o.piskunov@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] Divide box/ddl.test.lua test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox