From: "Maria Khaydich" <maria.khaydich@tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
"Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: netbox.self and connect should work interchangeably
Date: Tue, 03 Mar 2020 21:05:09 +0300 [thread overview]
Message-ID: <1583258709.640377144@f153.i.mail.ru> (raw)
In-Reply-To: <20200226135059.GJ404@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 3171 bytes --]
Both minor comments are fixed.
>Среда, 26 февраля 2020, 16:56 +03:00 от Igor Munkin <imun@tarantool.org>:
>
>Masha,
>
>Thanks for the patch! I left some nits below, please consider them.
>Otherwise, LGTM.
>
>On 27.01.20, Maria Khaydich wrote:
>>
>> Thank you for the review! All fixes below
>>
>> ----------------------------------------------------------------------
>> Branch:
>> https://github.com/tarantool/tarantool/compare/eljashm/gh-4513-netbox.self-convert-tuples-to-table-type
>> Issue:
>> https://github.com/tarantool/tarantool/issues/4513
>>
>> src/box/lua/net_box.lua | 8 +++-
>> test/app-tap/debug.result | 8 ++--
>> test/box-tap/net.box.test.lua | 3 +-
>> test/box/engine.cfg | 6 +++
>> ...ox-self-and-connect-interchangeable.result | 44 +++++++++++++++++++
>> ...-self-and-connect-interchangeable.test.lua | 20 +++++++++
>> test/box/suite.ini | 1 +
>> 7 files changed, 83 insertions(+), 7 deletions(-)
>> create mode 100644 test/box/engine.cfg
>> create mode 100644 test/box/gh-4513-netbox-self-and-connect-interchangeable.result
>> create mode 100644 test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua
>
><snipped>
>
>> diff --git a/test/box-tap/net.box.test.lua b/test/box-tap/net.box.test.lua
>> index a46f28ad0..577e97d78 100755
>> --- a/test/box-tap/net.box.test.lua
>> +++ b/test/box-tap/net.box.test.lua
>> @@ -30,5 +30,4 @@ test:ok(not pcall(function() conn.space._vspace:insert() end), "error handling")
>> -- cleanup
>> conn:close()
>> inspector:cmd('stop server second with cleanup=1')
>> -test:check()
>> -os.exit(0)
>> +os.exit(test:check() and 0 or 1)
>
>The changes are fine but look like not related to the subj.
>
>> diff --git a/test/box/engine.cfg b/test/box/engine.cfg
>
><snipped>
>
>> diff --git a/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua b/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua
>> new file mode 100644
>> index 000000000..5e8ae7465
>> --- /dev/null
>> +++ b/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua
>> @@ -0,0 +1,20 @@
>> +netbox = require('net.box')
>> +test_run = require('test_run').new()
>> +remote = test_run:get_cfg('remote') == 'true'
>> +test_run:cmd("setopt delimiter ';'")
>> +
>> +nb = nil
>> +if remote then
>> + box.schema.user.grant('guest','super')
>> + nb = netbox.connect(box.cfg.listen)
>> +else
>> + nb = netbox.self
>> +end;
>> +
>> +--
>> +-- netbox:self and netbox:connect should work interchangeably
>> +--
>> +test_run:cmd("setopt delimiter ''");
>
>Minor: The line above relates to the nb initialization, so it's better
>been placed before the comment. It's totally minor, feel free to ignore.
>
>> +type(nb:eval('return box.tuple.new{1}')) -- table
>> +type(nb:eval('return box.error.new(1, "test error")')) -- string
>> +type(nb:eval('return box.NULL')) -- cdata
>
><snipped>
>
>> --
>> 2.24.0
>
><snipped>
>
>--
>Best regards,
>IM
--
Maria Khaydich
[-- Attachment #2: Type: text/html, Size: 4536 bytes --]
next prev parent reply other threads:[~2020-03-03 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 17:08 Maria
2020-01-20 21:22 ` Vladislav Shpilevoy
2020-01-27 16:13 ` Maria Khaydich
2020-02-26 13:51 ` Igor Munkin
2020-03-03 18:05 ` Maria Khaydich [this message]
2020-03-03 22:49 ` Vladislav Shpilevoy
2020-03-06 12:19 ` Maria Khaydich
2020-03-08 22:57 ` Vladislav Shpilevoy
-- strict thread matches above, loose matches on Subject: below --
2019-12-12 21:28 Maria
2019-12-13 13:53 ` Oleg Babin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583258709.640377144@f153.i.mail.ru \
--to=maria.khaydich@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: netbox.self and connect should work interchangeably' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox