From: "Serge Petrenko" <sergepetrenko@tarantool.org>
To: "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn
Date: Sat, 29 Feb 2020 12:22:32 +0300 [thread overview]
Message-ID: <1582968152.19487183@f343.i.mail.ru> (raw)
In-Reply-To: <46414642-29a4-fb65-acc1-67bce6da14fb@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
>Суббота, 29 февраля 2020, 2:24 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:
>
>On 28/02/2020 09:34, Serge Petrenko wrote:
>> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't
>> fire in release builds, of course. Let's at least warn the user on an
>> attemt to write a record with a duplicate or otherwise broken lsn, and
>attemt -> attempt
>
>I fixed that on the branch by a force push.
Thanks!
--
Serge Petrenko
[-- Attachment #2: Type: text/html, Size: 876 bytes --]
next prev parent reply other threads:[~2020-02-29 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:34 [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 1/4] box: expose box_is_orphan method Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn Serge Petrenko
2020-02-28 23:24 ` Vladislav Shpilevoy
2020-02-29 9:22 ` Serge Petrenko [this message]
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 3/4] replication: implement an instance id filter for relay Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 4/4] replication: do not relay rows coming from a remote instance back to it Serge Petrenko
2020-02-28 23:24 ` [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance Vladislav Shpilevoy
2020-03-02 4:32 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582968152.19487183@f343.i.mail.ru \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox