Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: "Konstantin Osipov" <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/4] Safe truncation and deletion
Date: Sat, 15 Feb 2020 00:12:06 +0300	[thread overview]
Message-ID: <1581714726.49093638@f467.i.mail.ru> (raw)
In-Reply-To: <20200214210005.GB12053@atlas>

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]


I sent 2 versions of this patchset. Here is the second one
with discussed approach:
https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/014191.html
And tarantool/small patch:
https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/014190.html 
>Суббота, 15 февраля 2020, 0:00 +03:00 от Konstantin Osipov <kostja.osipov@gmail.com>:
> 
>* Ilya Kosarev < i.kosarev@tarantool.org > [20/02/14 22:41]:
>> Changes in v2:
>> Approach changed completely: now we are not trying to allocate
>> service tuples in some safe way, but increasing memtx quota so
>> that space:truncate() and space:delete() won't fail on allocation.
>
>
>>
>> Changes in v3:
>> Now we are not increasing memtx quota. Instead we just set a flag to
>> allow quota overuse for space:truncate() and space:delete().
>>
>> Changes in v4:
>> improved quota on/off flag style
>> took into account fail cases for box_upsert in space_truncate
>> now we are switching the quota off for deletion only in case there is
>> OutOfMemory error in diag
>> removed extra checks
>> added tests
>
>Is it intentional that first you discuss the
>recommendation I make on the mailing list, and then silently
>disregard it?
>
>--
>Konstantin Osipov, Moscow, Russia 
 
 
--
Ilya Kosarev
 

[-- Attachment #2: Type: text/html, Size: 2004 bytes --]

      reply	other threads:[~2020-02-14 21:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 19:39 Ilya Kosarev
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 1/4] small: bump small version Ilya Kosarev
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 2/4] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 3/4] memtx: allow quota overuse for truncation and deletion Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 19:39 ` [Tarantool-patches] [PATCH v4 4/4] test: add tests " Ilya Kosarev
2020-02-14 23:50   ` Vladislav Shpilevoy
2020-02-14 21:00 ` [Tarantool-patches] [PATCH v4 0/4] Safe " Konstantin Osipov
2020-02-14 21:12   ` Ilya Kosarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581714726.49093638@f467.i.mail.ru \
    --to=i.kosarev@tarantool.org \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v4 0/4] Safe truncation and deletion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox