From: "Sergey Petrenko" <sergepetrenko@tarantool.org> To: "Konstantin Osipov" <kostja.osipov@gmail.com> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn Date: Fri, 14 Feb 2020 01:05:49 +0300 [thread overview] Message-ID: <1581631549.621693072@f191.i.mail.ru> (raw) In-Reply-To: <20200213064831.GB17713@atlas> [-- Attachment #1: Type: text/plain, Size: 742 bytes --] >Четверг, 13 февраля 2020, 9:48 +03:00 от Konstantin Osipov <kostja.osipov@gmail.com>: > >* sergepetrenko < sergepetrenko@tarantool.org > [20/02/13 09:34]: >> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't >> fire in release builds, of course. So we better panic on an attemt to >> write a record with a duplicate or otherwise broken lsn. >> > >It should be a warning in production. You can't crash production >deploy because of a server bug, and lsn inconsistency is always a >server bug. Well, this inconsistency yields a WAL that cannot be recovered from. But I don't have a strong opinion here. I changed it to a warning in v2. > > >-- >Konstantin Osipov, Moscow, Russia -- Sergey Petrenko [-- Attachment #2: Type: text/html, Size: 1386 bytes --]
next prev parent reply other threads:[~2020-02-13 22:05 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-12 23:50 [Tarantool-patches] [PATCH 0/2] replication: fix applying of rows originating from local instance sergepetrenko 2020-02-12 23:51 ` [Tarantool-patches] [PATCH 1/2] replication: correctly check for rows to skip in applier sergepetrenko 2020-02-13 6:47 ` Konstantin Osipov 2020-02-13 6:58 ` Konstantin Osipov 2020-02-13 22:03 ` Sergey Petrenko 2020-02-13 22:10 ` Sergey Petrenko 2020-02-12 23:51 ` [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn sergepetrenko 2020-02-13 6:48 ` Konstantin Osipov 2020-02-13 22:05 ` Sergey Petrenko [this message] 2020-02-14 7:26 ` Konstantin Osipov 2020-02-13 6:48 ` [Tarantool-patches] [PATCH 0/2] replication: fix applying of rows originating from local instance Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1581631549.621693072@f191.i.mail.ru \ --to=sergepetrenko@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox