From: "Maria Khaydich" <maria.khaydich@tarantool.org>
To: tarantool-patches <tarantool-patches@dev.tarantool.org>,
"Alexander Turenko" <alexander.turenko@tarantool.org>,
"Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Subject: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac
Date: Mon, 10 Feb 2020 21:45:13 +0300 [thread overview]
Message-ID: <1581360313.873049294@f221.i.mail.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]
Stress tests failed due to lack of fds for mac. The problem was in the
libev library where DARWIN_UNLIMITED_SELECT flag was defined too late
to do the trick.
Closes #3867, #4673
---
Issues:
https://github.com/tarantool/tarantool/issues/3867
https://github.com/tarantool/tarantool/issues/4673
Branch:
https://github.com/tarantool/tarantool/compare/eljashm/gh-4673-replication-flaky-test
third_party/libev/ev.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/third_party/libev/ev.c b/third_party/libev/ev.c
index 6a2648591..b65a77e0e 100644
--- a/third_party/libev/ev.c
+++ b/third_party/libev/ev.c
@@ -196,6 +196,14 @@
# define ECB_NO_SMP 1
#endif
+/* OS X, in its infinite idiocy, actually HARDCODES
+ * a limit of 1024 into their select. Where people have brains,
+ * OS X engineers apparently have a vacuum. Or maybe they were
+ * ordered to have a vacuum, or they do anything for money.
+ * This might help. Or not.
+ */
+#define _DARWIN_UNLIMITED_SELECT 1
+
#ifndef _WIN32
# include <sys/time.h>
# include <sys/wait.h>
@@ -211,14 +219,6 @@
# undef EV_AVOID_STDIO
#endif
-/* OS X, in its infinite idiocy, actually HARDCODES
- * a limit of 1024 into their select. Where people have brains,
- * OS X engineers apparently have a vacuum. Or maybe they were
- * ordered to have a vacuum, or they do anything for money.
- * This might help. Or not.
- */
-#define _DARWIN_UNLIMITED_SELECT 1
-
/* this block tries to deduce configuration from header-defined symbols and defaults */
/* try to deduce the maximum number of signals on this platform */
--
2.24.0
--
Maria Khaydich
[-- Attachment #2: Type: text/html, Size: 2507 bytes --]
next reply other threads:[~2020-02-10 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:45 Maria Khaydich [this message]
2020-02-13 0:14 ` Vladislav Shpilevoy
2020-02-15 17:50 ` Konstantin Osipov
2020-02-15 20:19 ` Alexander Turenko
2020-02-17 7:40 ` Konstantin Osipov
2020-02-17 10:00 ` Alexander Turenko
2020-03-03 14:58 ` [Tarantool-patches] [PATCH] libev: update to version 4.32 Maria Khaydich
2020-04-20 6:30 ` [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac Alexander Turenko
2020-04-20 7:59 ` Kirill Yukhin
2020-04-21 17:01 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581360313.873049294@f221.i.mail.ru \
--to=maria.khaydich@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox