From: "Alexander Tikhonov" <avtikhon@tarantool.org>
To: "Alexander Turenko" <alexander.turenko@tarantool.org>
Cc: "Oleg Piskunov" <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v9] gitlab-ci: push Deb/RPM packages to S3 based repos
Date: Mon, 03 Feb 2020 17:41:03 +0300 [thread overview]
Message-ID: <1580740863.353391507@f333.i.mail.ru> (raw)
In-Reply-To: <20200203134225.r7ptxf7shhzbhozg@tkn_work_nb>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Alexander, thanks a lot for the review, I've made all the changes as you suggested.
>Понедельник, 3 февраля 2020, 16:42 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>> S3 compatible storage:
>>
>> | - live
>> | - 1.10
>> | - 2.1
>> | - 2.2
>> | - ...
>> | - release
>> | - 1.10
>> | - 2.1
>> | - 2.2
>> | - ...
>
>Please, format it as a tree:
>
> | - live
> | - 1.10
>
>And so on.
>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 3af5a3c8a..8d2a15ce8 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -8,9 +8,24 @@ variables:
>>
>> .release_only_template: &release_only_definition
>> only:
>> - refs:
>> - - master
>> - - /^.*-full-ci$/
>> + - master
>
>It is almost same as &deploy_only_definition below. I don't found strict
>correspondence between templates and different kinds of jobs we have.
>Looks messy...
>
>> +
>> +.fullci_only_template: &fullci_only_definition
>> + only:
>> + - /^.*-full-ci$/
>
>It is not used anywhere.
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 1716 bytes --]
next prev parent reply other threads:[~2020-02-03 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 18:55 Alexander V. Tikhonov
2020-02-03 13:42 ` Alexander Turenko
2020-02-03 14:41 ` Alexander Tikhonov [this message]
2020-02-03 13:45 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580740863.353391507@f333.i.mail.ru \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9] gitlab-ci: push Deb/RPM packages to S3 based repos' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox