Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Sergey Voinov" <sergeiv@tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Increase limits for debug.traceback
Date: Tue, 21 Jan 2020 11:08:09 +0300	[thread overview]
Message-ID: <1579594089.895612193@f192.i.mail.ru> (raw)
In-Reply-To: <20191220122548.GA31304@tarantool.org>

Hi Igor!

Thanks for your elaborate review!
Please see my answers.


>>  /* Note: changing the following defines breaks the Lua 5.1 ABI. */
>> -#define LUA_INTEGERptrdiff_t
>> -#define LUA_IDSIZE60/* Size of lua_Debug.short_src. */
>> +#define LUA_INTEGER    ptrdiff_t
>> +#define LUA_IDSIZE    128 /* Size of lua_Debug.short_src. */
>> +#define LUA_IDSIZE_ERR  60  /* Size of error message */
>
>I don't get the reason to introduce a separate constant for a single
>line sources. Could you please provide a bit more extended rationale?

The problem here is that if I allow 128 for size of error messages, all error outputs will be longer and there will be need to fix vast amount of test result outputs (.result files). Also, these long outputs will flood tarantool output. I don't think there is a reason to increase error message size. Do you?

Thanks.

-- 
Sergey Voinov

  reply	other threads:[~2020-01-21  8:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  8:56 Sergey Voinov
2019-12-20 12:25 ` Igor Munkin
2020-01-21  8:08   ` Sergey Voinov [this message]
2020-01-15 10:17 ` Sergey Ostanevich
2020-01-20 10:22   ` Sergey Voinov
2020-01-22 14:51 Sergey Voinov
2020-01-25 19:35 ` Igor Munkin
2020-02-21 11:00 ` Sergey Ostanevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1579594089.895612193@f192.i.mail.ru \
    --to=sergeiv@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Increase limits for debug.traceback' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox