From: "Alexander Tikhonov" <avtikhon@tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/3] gitlab-ci: implement packing into MCS S3 v.4
Date: Tue, 14 Jan 2020 08:00:47 +0300 [thread overview]
Message-ID: <1578978047.148623204@f184.i.mail.ru> (raw)
In-Reply-To: <20200113170221.GK31304@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
Igor,
Thank you for all the reviews, I've squashed all changes into the single commit and sent
it on the review of A. Turenko.
Alexander, please proceed the review.
>Понедельник, 13 января 2020, 20:04 +03:00 от Igor Munkin <imun@tarantool.org>:
>
>Sasha,
>
>Thanks, you've fixed almost everything. Sorry, two my remarks were
>slightly misleading, thus I extended them in the corresponding patch
>in this patchset. Please consider them, since everything else LGTM.
>
>I guess after the final fixes you can squash everithing into a single
>commit and ask Sasha Tu to proceed with the patch.
>
>On 13.01.20, Alexander V. Tikhonov wrote:
>> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3380-push-packages-s3-full-ci
>> Issue: https://github.com/tarantool/tarantool/issues/3380
>>
>> v4: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013568.html
>> v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-December/013060.html
>> v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012352.html
>> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/012021.html
>>
>> Changes v4:
>> - minor corrections
>>
>> Changes v3:
>> - common code parts merged to standalone routines
>> - corrected code style, minor updates
>> - script is ready for release
>>
>> Changes v2:
>> - made changes in script from draft to pre-release stages
>>
>> Alexander V. Tikhonov (3):
>> gitlab-ci: implement packing into MCS S3
>> Testing changes after 2nd review on S3
>> Testing changes after 3rd review on S3
>>
>> .gitlab-ci.yml | 5 +-
>> .gitlab.mk | 20 +-
>> .travis.mk | 41 ++-
>> tools/add_pack_s3_repo.sh | 527 ++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 567 insertions(+), 26 deletions(-)
>> create mode 100755 tools/add_pack_s3_repo.sh
>>
>> --
>> 2.17.1
>>
>
>--
>Best regards,
>IM
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 3311 bytes --]
prev parent reply other threads:[~2020-01-14 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 12:04 Alexander V. Tikhonov
2020-01-13 12:04 ` [Tarantool-patches] [PATCH v4 1/3] gitlab-ci: implement packing into MCS S3 Alexander V. Tikhonov
2020-01-13 12:04 ` [Tarantool-patches] [PATCH v4 2/3] Testing changes after 2nd review on S3 Alexander V. Tikhonov
2020-01-13 12:04 ` [Tarantool-patches] [PATCH v4 3/3] Testing changes after 3rd " Alexander V. Tikhonov
2020-01-13 16:54 ` Igor Munkin
2020-01-13 17:02 ` [Tarantool-patches] [PATCH v4 0/3] gitlab-ci: implement packing into MCS S3 v.4 Igor Munkin
2020-01-14 5:00 ` Alexander Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578978047.148623204@f184.i.mail.ru \
--to=avtikhon@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 0/3] gitlab-ci: implement packing into MCS S3 v.4' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox