Re: [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net

["Alexander Tikhonov" <avtikhon@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2403 bytes --]

Igor, thanks for the review, I've checked this issue manually and found that
wget returns with 500 HTTP respond and there is no any option for it that
could try to resend it automatically, in the same situation I saw that curl
worked without any fails at all. I've investigated the differences between
wget and curl and found only difference that could cause that curl worked
better in "happy eyeballs":

https://en.wikipedia.org/wiki/Happy_Eyeballs

also you can find the more differences described here:
http://ubuntu.fliplinux.com/curl-wget.html

>Среда, 18 декабря 2019, 18:57 +03:00 от Igor Munkin <imun@tarantool.org>:
>
>Sasha,
>
>Thanks for the patch! I see there was an issue with upstream, therefore
>you moved the link to github release. However I still don't get your
>motivation for replacing wget with curl (and as I see in the v1 review
>neither does Sasha Tu.). Could you please provide a bit more extended
>rationale for such substitution?
>
>On 10.12.19, Alexander V. Tikhonov wrote:
>> Found that wget may fail on downloading the file from flaky
>> available servers with 500 HTTP error, like it was seen on
>> icu4c sources downloading, please check the issue:
>>  https://sourceforge.net/p/forge/site-support/20071/
>> 
>> Found that curl successfully downloads needed files even in
>> such situations. Decided to use curl instead of wget tool
>> to avoid of such errors feather.
>> 
>> Also found that sourceforge site too often has issues and
>> responds with 500 HTTP error. Decided to use the link from
>> github instead of sourceforge to download the icu4c sources,
>> as suggested on icu4c web site.
>> ---
>>  Dockerfile.staticbuild | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
>> index 0424179a2..49895a4de 100644
>> --- a/Dockerfile.staticbuild
>> +++ b/Dockerfile.staticbuild
>> @@ -48,7 +48,7 @@ RUN set -x && \
>> 
>>  RUN set -x && \
>>      cd / && \
>> -    wget  http://download.icu-project.org/files/icu4c/62.1/icu4c-62_1-src.tgz && \
>> +    curl -O -L  https://github.com/unicode-org/icu/releases/download/release-62-1/icu4c-62_1-src.tgz && \
>>      tar -xvf icu4c-62_1-src.tgz && \
>>      cd icu/source && \
>>      ./configure --with-data-packaging=static --enable-static --enable-shared && \
>> -- 
>> 2.17.1
>> 
>
>-- 
>Best regards,
>IM


-- 
Alexander Tikhonov

[-- Attachment #2: Type: text/html, Size: 3454 bytes --]