Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] fix box_set_replication issues & stabilize quorum test
Date: Mon, 25 Nov 2019 14:50:38 +0300	[thread overview]
Message-ID: <1574682638.833007568@f508.i.mail.ru> (raw)
In-Reply-To: <07825b6b-7064-2f46-4409-2571e6e32d6a@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi!

Thanks for your review.

Sent v3 of the patchset considering mentioned drawbacks.


>Воскресенье, 24 ноября 2019, 18:53 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:
>
>Hi!
>
>Please, specify branch and issue links.
>
>Issue:  https://github.com/tarantool/tarantool/issues/4586
>Branch:  https://github.com/tarantool/tarantool/commits/i.kosarev/gh-4586-fix-quorum-test
>
>Add 'Changes in V2' section, when you send a new version.
>
>On 23/11/2019 22:53, Ilya Kosarev wrote:
>> This patchset fixes appliers pruning in replicaset_update, anon
>> replicas iteration issues in replicaset_follow and stabilizes quorum
>> test. It also stabilizes tcp_connect in test_run:cmd().
>> 
>> Ilya Kosarev (4):
>>   test: update test-run
>>   replication: fix appliers pruning
>>   replication: make anon replicas iteration safe
>>   test: stabilize quorum test conditions
>> 
>>  src/box/replication.cc                        | 17 +++---
>>  test-run                                      |  2 +-
>>  .../box_set_replication_stress.result         | 38 +++++++++++++
>>  .../box_set_replication_stress.test.lua       | 17 ++++++
>>  test/replication/quorum.result                | 54 ++++++++++++++-----
>>  test/replication/quorum.test.lua              | 24 +++++----
>>  6 files changed, 121 insertions(+), 31 deletions(-)
>>  create mode 100644 test/replication/box_set_replication_stress.result
>>  create mode 100644 test/replication/box_set_replication_stress.test.lua
>> 


-- 
Ilya Kosarev

[-- Attachment #2: Type: text/html, Size: 2771 bytes --]

      reply	other threads:[~2019-11-25 11:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 21:53 Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 1/4] test: update test-run Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 2/4] replication: fix appliers pruning Ilya Kosarev
2019-11-24 15:54   ` Vladislav Shpilevoy
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 3/4] replication: make anon replicas iteration safe Ilya Kosarev
2019-11-23 21:53 ` [Tarantool-patches] [PATCH v2 4/4] test: stabilize quorum test conditions Ilya Kosarev
2019-11-24 15:54   ` Vladislav Shpilevoy
2019-11-24 15:53 ` [Tarantool-patches] [PATCH v2 0/4] fix box_set_replication issues & stabilize quorum test Vladislav Shpilevoy
2019-11-25 11:50   ` Ilya Kosarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574682638.833007568@f508.i.mail.ru \
    --to=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/4] fix box_set_replication issues & stabilize quorum test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox