From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: "Kirill Yukhin" <kyukhin@tarantool.org>
Cc: tarantool-patches <tarantool-patches@freelists.org>,
tarantool-patches <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 17/20] refactoring: remove exceptions from fk_constraint_def_new_from_tuple
Date: Wed, 13 Nov 2019 16:50:21 +0300 [thread overview]
Message-ID: <1573653021.950740091@f419.i.mail.ru> (raw)
In-Reply-To: <20191113133416.dtdgl63r7erfwfht@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hi!
Yes, it happened due to changes in master. Fixed the patch. Sent it in-reply to your letter.
Sincerely,
Ilya Kosarev
>Среда, 13 ноября 2019, 16:34 +03:00 от Kirill Yukhin <kyukhin@tarantool.org>:
>
>Hello,
>
>On 23 сен 18:57, Ilya Kosarev wrote:
>> fk_constraint_def_new_from_tuple is used in
>> on_replace_dd_fk_constraint therefore it has to be cleared from
>> exceptions. Now it doesn't throw any more. It means we also need
>> to clear from exceptions it's subsidiary function: decode_fk_links.
>> Their usages are updated. Some _xc functions, not needed any more,
>> are removed.
>>
>> Part of #4247
>
>Your patch gives compilation error on recent master.
>
>--
>Regards, Kirill Yukhin
>
--
Ilya Kosarev
[-- Attachment #2: Type: text/html, Size: 1606 bytes --]
prev parent reply other threads:[~2019-11-13 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <15e506eb070ddbb0bbb0c0f4388958738f1fbc9a.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <20191030085942.GA35607@tarantool.org>
2019-10-30 10:47 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 07/20] refactoring: remove exceptions from index_def_new_from_tuple Ilya Kosarev
2019-10-31 5:02 ` Sergey Ostanevich
[not found] ` <09dd946a8304f3865ada1638f610a4f9ba2fd3eb.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <20191030103454.GB35607@tarantool.org>
2019-10-30 11:02 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 08/20] refactoring: remove exceptions from func_def_new_from_tuple Ilya Kosarev
2019-11-11 14:36 ` Sergey Ostanevich
[not found] ` <c7b7c7fd16803e60296be60c3e545dbf2ab61ae8.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <1573329671.649762688@f148.i.mail.ru>
2019-11-09 22:52 ` [Tarantool-patches] [tarantool-patches] [PATCH v4 11/20] refactoring: use non _xc version of functions in triggers Ilya Kosarev
2019-11-11 14:37 ` Sergey Ostanevich
[not found] ` <e5cebfe21734bcfe8b7a8b477968668620cb3aa8.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <20191112105951.GC10433@tarantool.org>
2019-11-12 15:32 ` [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 12/20] refactoring: remove exceptions from space_def_new_from_tuple Ilya Kosarev
2019-11-19 15:16 ` Ilya Kosarev
2019-12-16 11:55 ` [Tarantool-patches] [tarantool-patches] Re[2]: " Sergey Ostanevich
[not found] ` <6f586562e3079b4ca5776b74913894db73bd979f.1569253692.git.i.kosarev@tarantool.org>
[not found] ` <20191113133416.dtdgl63r7erfwfht@tarantool.org>
2019-11-13 13:49 ` [Tarantool-patches] [PATCH] refactoring: remove exceptions from fk_constraint_def_new_from_tuple Ilya Kosarev
2019-11-13 16:02 ` Kirill Yukhin
2019-11-13 13:50 ` Ilya Kosarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573653021.950740091@f419.i.mail.ru \
--to=i.kosarev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 17/20] refactoring: remove exceptions from fk_constraint_def_new_from_tuple' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox