From: "Maria Khaydich" <maria.khaydich@tarantool.org>
To: "Бабин Олег" <olegrok@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Netbox connection and self are interchangable
Date: Thu, 07 Nov 2019 17:27:12 +0300 [thread overview]
Message-ID: <1573136832.910959040@f399.i.mail.ru> (raw)
In-Reply-To: <1573135710.194904005@f535.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Thank you for the comment!
I’ve checked the behavior and previous version does not indeed cover the case with box.NULL. Suitable fix and tests were added.
>Четверг, 7 ноября 2019, 17:08 +03:00 от Бабин Олег <olegrok@tarantool.org>:
>
>Maria, thanks for your patch!
>
>But as I see you don't consider the case of box.NULL that has 'cdata' type, but doesn't have
>__serialize metamethod.
>
>It will lead to an error:
>```
>- error: '[string "return x:__serialize()"]:1: ''void *'' has no member named ''__serialize'''
>...
>```
>>Четверг, 7 ноября 2019, 16:47 +03:00 от Maria < maria.khaydich@tarantool.org >:
>>
>>+ if type(res) == 'cdata' then
>>+ results[n] = res:__serialize()
>>+ end
>
>--
>Oleg Babin
--
Maria Khaydich
[-- Attachment #2: Type: text/html, Size: 2214 bytes --]
next prev parent reply other threads:[~2019-11-07 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 13:47 Maria
2019-11-07 14:08 ` Бабин Олег
2019-11-07 14:27 ` Maria Khaydich [this message]
2019-11-07 18:40 ` Бабин Олег
-- strict thread matches above, loose matches on Subject: below --
2019-10-29 11:46 Maria
2019-10-30 8:59 ` Kirill Yukhin
2019-10-24 8:45 Maria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573136832.910959040@f399.i.mail.ru \
--to=maria.khaydich@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Netbox connection and self are interchangable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox