From: "Ilya Kosarev" <i.kosarev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH] replication: freeze join vclock before read view
Date: Mon, 28 Oct 2019 15:25:14 +0300 [thread overview]
Message-ID: <1572265514.506221512@f402.i.mail.ru> (raw)
In-Reply-To: <20191028064316.GA1464@atlas>
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Ok, as far as wal_begin_checkpoint does pretty much the same thing as
wal_sync and allows us to obtain vclock in a more direct way, i see why
we should prefer it. Although it brings slight overhead comparing to
wal_sync, it doesn't really seem to be significant. Sent v2 of the patch.
>Понедельник, 28 октября 2019, 9:43 +03:00 от Konstantin Osipov <kostja.osipov@gmail.com>:
>
>* Ilya Kosarev < i.kosarev@tarantool.org > [19/10/28 09:41]:
>> The idea of the patch "relay: join new replicas off read view"
>> (6332aca655ae7f95d391bdc0109e79915f6e6ad0), which brought us to the
>> currently discussed patch, was to get rid of checkpoint as a prerequisite
>> of replica joining. Therefore, why would we need to perform checkpointing
>> here and how is it better than proposed approach, which seems to be more
>> lightweight?
>
>wel_begin_checkpoint() doesn't perform a checkpoint. It ensures
>the current state of the database is flushed to the write ahead log.
>
>I don't suggest a full blown checkpoint is initiated.
>
>
>--
>Konstantin Osipov, Moscow, Russia
>
--
Ilya Kosarev
[-- Attachment #2: Type: text/html, Size: 1612 bytes --]
parent reply other threads:[~2019-10-28 12:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191028064316.GA1464@atlas>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572265514.506221512@f402.i.mail.ru \
--to=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH] replication: freeze join vclock before read view' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox