From: "Sergey Ostanevich" <sergos@tarantool.org>
To: "Cyrill Gorcunov" <gorcunov@gmail.com>
Cc: tarantool-patches <tarantool-patches@freelists.org>,
"Alexander Turenko" <alexander.turenko@tarantool.org>,
"Konstantin Osipov" <kostja.osipov@gmail.com>
Subject: [tarantool-patches] Re[2]: [tarantool-patches] [PATCH 1/6] box/console: Add mapping for direct symbols
Date: Tue, 10 Sep 2019 06:59:03 +0300 [thread overview]
Message-ID: <1568087943.236858627@f129.i.mail.ru> (raw)
In-Reply-To: <20190909155422.GD1508@uranus>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Sure, separate patch is OK if you do not envision any other problem with such a move.
Sent from Mail.ru app for iOS
Monday, 9 September 2019, 18:54 +0300 from gorcunov@gmail.com <gorcunov@gmail.com>:
>On Mon, Sep 09, 2019 at 06:11:44PM +0300, Sergey Ostanevich wrote:
>> Cyrill,
>>
>> Why not to move the map_direct_symbols to the module level, so that
>> creation and
>> fill of the table will happens only once and not at every call to the
>> output handler?
>
>Well, initially I thought to keep such things inside serializer helper
>so that if we need we will easily extend this table and the change
>will be inside function context. I must admit I think all this comes
>from a strong habbit of working with compilers where such thing would
>be simply optimized. That said I agree we should do so.
>
>I think this issue could be addressed on top as a separate patch?
>Just to not resend the whole series.
[-- Attachment #2: Type: text/html, Size: 1867 bytes --]
next prev parent reply other threads:[~2019-09-10 3:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 21:28 [tarantool-patches] [PATCH v3 0/6] box/console: Improve lua mode for remote console Cyrill Gorcunov
2019-09-05 21:28 ` [tarantool-patches] [PATCH 1/6] box/console: Add mapping for direct symbols Cyrill Gorcunov
2019-09-09 15:11 ` [tarantool-patches] " Sergey Ostanevich
2019-09-09 15:54 ` [tarantool-patches] " Cyrill Gorcunov
2019-09-10 3:59 ` Sergey Ostanevich [this message]
2019-09-05 21:28 ` [tarantool-patches] [PATCH 2/6] box/console: Add explicit output EOS mapping Cyrill Gorcunov
2019-09-05 21:28 ` [tarantool-patches] [PATCH 3/6] box/console: Refactor command handling Cyrill Gorcunov
2019-09-05 21:28 ` [tarantool-patches] [PATCH 4/6] box/console: Fix hang in remote console lua mode Cyrill Gorcunov
2019-09-05 21:28 ` [tarantool-patches] [PATCH 5/6] box/console: Provide console.eos() api Cyrill Gorcunov
2019-09-05 21:28 ` [tarantool-patches] [PATCH 6/6] box/console: Rename output_parse to parse_output Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568087943.236858627@f129.i.mail.ru \
--to=sergos@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re[2]: [tarantool-patches] [PATCH 1/6] box/console: Add mapping for direct symbols' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox