From: "Alexander Tikhonov" <avtikhon@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build
Date: Fri, 16 Aug 2019 12:57:58 +0300 [thread overview]
Message-ID: <1565949478.621885683@f478.i.mail.ru> (raw)
In-Reply-To: <20190816023008.ean2vrvwablefviu@tkn_work_nb>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
I'm not quiet happy of cleanup roll back, but anyway I did it for all places that were changed by it, in places where the code was deleted I've left it, as it doesn't change the history of the code.
Alexander
>Пятница, 16 августа 2019, 5:32 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>I looked briefly and it seems to be okay. But, please, remove cleanup
>changes from the dockerfile: they hide real changes and bloats the
>patch.
>
>I'll look deeper when you'll update the patch.
>
>WBR, Alexander Turenko.
>
>> -RUN set -x \
>> - && yum -y install \
>> +RUN set -x && \
>> + yum -y install \
>
>I meant this kind of changes.
>
>> -RUN yum -y install ncurses-static readline-static zlib-static pcre-static glibc-static
>> + yum -y install \
>> + ncurses-static \
>> + readline-static \
>> + zlib-static \
>> + pcre-static \
>> + glibc-static && \
>> + yum -y install \
>> + python-devel \
>> + python-pip
>
>This.
>
>> +WORKDIR /
>>
>> RUN set -x && \
>> - cd / && \
>> curl -O -L https://www.openssl.org/source/openssl-1.1.0h.tar.gz && \
>> tar -xvf openssl-1.1.0h.tar.gz && \
>> cd openssl-1.1.0h && \
>
>And this.
>
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 2084 bytes --]
prev parent reply other threads:[~2019-08-16 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 4:32 [tarantool-patches] " Alexander V. Tikhonov
2019-08-16 2:30 ` [tarantool-patches] " Alexander Turenko
2019-08-16 9:57 ` Alexander Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565949478.621885683@f478.i.mail.ru \
--to=avtikhon@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox