From: "Sergey Petrenko" <sergepetrenko@tarantool.org> To: "Alexander Turenko" <alexander.turenko@tarantool.org> Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems. Date: Tue, 23 Jul 2019 21:25:21 +0300 [thread overview] Message-ID: <1563906321.235667177@f430.i.mail.ru> (raw) In-Reply-To: <20190723094016.jzswrwj2zrqheedv@tkn_work_nb> [-- Attachment #1: Type: text/plain, Size: 951 bytes --] Hi! >Вторник, 23 июля 2019, 12:40 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>: > >> I addressed this issue in a patch to tarantool/libyaml. Please check it out. >> This patch remains intact. > >Okay. I don't have objections, but one comment. > >> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w") >> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99") > >Maybe it worth to declare a loop variable outside a loop initialization >statement in libyaml (and update the upstream PR)? I mean that if all >libyaml code follow C89, then we maybe should do it too in our changes. >What do you think? This seems reasonable. I updated both branches ( https://github.com/tarantool/libyaml/tree/sp/static-linking and https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci ) I've also updated the pull request to libyaml upstream. > > -- Sergey Petrenko [-- Attachment #2: Type: text/html, Size: 2268 bytes --]
next prev parent reply other threads:[~2019-07-23 18:25 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-21 13:25 [tarantool-patches] " Serge Petrenko 2019-07-22 7:09 ` [tarantool-patches] " Alexander Turenko 2019-07-22 21:48 ` [tarantool-patches] Re[2]: " Sergey Petrenko 2019-07-23 9:40 ` [tarantool-patches] " Alexander Turenko 2019-07-23 18:25 ` Sergey Petrenko [this message] 2019-07-24 8:03 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1563906321.235667177@f430.i.mail.ru \ --to=sergepetrenko@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [tarantool-patches] Re: [PATCH] build: enable bundled libyaml for all systems.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox