From: "Sergei Voronezhskii" <sergw@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "Alexander Turenko" <alexander.turenko@tarantool.org>,
"Kirill Yukhin" <kyukhin@tarantool.org>,
"Vladimir Davydov" <vdavydov@tarantool.org>
Subject: Re[2]: [PATCH v2] test: enable parallel mode for wall_off tests
Date: Tue, 27 Nov 2018 16:09:06 +0300 [thread overview]
Message-ID: <1543324146.311548723@f550.i.mail.ru> (raw)
In-Reply-To: <20180919165750.ew3lv22q3gbtxdew@tkn_work_nb>
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
Hello
I've rebased on 2.1
BUILD: https://travis-ci.org/tarantool/tarantool/builds/460238498
BRANCH: https://github.com/tarantool/tarantool/tree/sergw/enable-parallel-test-wal-off-clean-2.1
>Среда, 19 сентября 2018, 19:57 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>Hi!
>
>Comments are below.
>
>WBR, Alexander Turenko.
>
>Maybe we should place the fix on top of 1.9. I asked Kostya O. and
>Kirill Yu. about that in the chat, please ping them and proceed
>appropriately.
>
>> enable parallel mode for wall_off tests
>
>wall -> wal
>
>> diff --git a/test/wal_off/lua.test.lua b/test/wal_off/lua.test.lua
>> index 7daf9f3f6..02ec9e795 100644
>> --- a/test/wal_off/lua.test.lua
>> +++ b/test/wal_off/lua.test.lua
>> @@ -1,5 +1,6 @@
>> env = require('test_run')
>> test_run = env.new()
>> +test_run:cmd("restart server default with cleanup=1")
>
>So the approach is to restart the server with clean up for each tests.
>It will slows down the execution. The another way you propose (w/ spaces
>renaming) seems to be better for me.
>
>Anyway, you don't describe a reason why exactly this is needed. How we
>can meet an inconsistent state if a server was not restarted or
>restarted with clean up? I propose to describe problems you fix in the
>commit message, otherwise I'll need to investigate the issue again after
>you to understand it and give the review.
--
Sergei Voronezhskii
[-- Attachment #2: Type: text/html, Size: 2252 bytes --]
next prev parent reply other threads:[~2018-11-27 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 13:11 [tarantool-patches] [PATCH] " Sergei Voronezhskii
2018-09-17 13:31 ` [tarantool-patches] " Alexander Turenko
2018-09-18 16:10 ` [tarantool-patches] [PATCH v2] " Sergei Voronezhskii
2018-09-19 16:57 ` [tarantool-patches] " Alexander Turenko
2018-09-21 12:44 ` [tarantool-patches] [PATCH] test: enable parallel mode for wal_off tests Sergei Voronezhskii
2018-09-22 1:44 ` Alexander Turenko
2018-09-23 22:40 ` Re[2]: " Sergei Voronezhskii
2018-09-23 22:53 ` [tarantool-patches] " Alexander Turenko
2018-09-25 17:10 ` Vladimir Davydov
2018-09-25 17:44 ` Alexander Turenko
2018-11-27 13:09 ` Sergei Voronezhskii [this message]
2018-11-28 14:11 ` [tarantool-patches] Re: [PATCH] test: enable parallel mode for wall_off tests Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543324146.311548723@f550.i.mail.ru \
--to=sergw@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov@tarantool.org \
--subject='Re: Re[2]: [PATCH v2] test: enable parallel mode for wall_off tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox