From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "v.shpilevoy@tarantool.org" <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 08/10] sql: new _trigger space format with space_id
Date: Fri, 15 Jun 2018 19:21:28 +0300 [thread overview]
Message-ID: <153b4330-dc3d-b7fc-e251-149f7257a2b5@tarantool.org> (raw)
In-Reply-To: <41a4720e-ecf1-51c1-db01-f0c9ea69479d@tarantool.org>
> 1. Please, do not send binary files.
ok.
> 2. Please, add a test that t1t == box.space.T.id. Your current test would pass
> even if t1t.id == t2t.id == -100.
+assert(t1t.space_id == box.space.T.id)
next prev parent reply other threads:[~2018-06-15 16:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 17:32 [tarantool-patches] [PATCH v3 00/10] sql: remove Triggers to server Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 01/10] box: move db->pShchema init to sql_init Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 10/10] sql: VDBE tests for trigger existence Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-19 10:24 ` Vladislav Shpilevoy
2018-06-19 15:12 ` Kirill Shcherbatov
2018-06-19 15:23 ` Vladislav Shpilevoy
2018-06-20 6:38 ` Kirill Shcherbatov
2018-06-20 8:10 ` Vladislav Shpilevoy
2018-06-20 8:24 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref Kirill Shcherbatov
2018-06-14 22:46 ` [tarantool-patches] " n.pettik
2018-06-15 9:25 ` Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 03/10] sql: fix sql len in tarantoolSqlite3RenameTrigger Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 04/10] box: port schema_find_id to C Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 22:46 ` n.pettik
2018-06-15 9:25 ` Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 05/10] sql: refactor sql_expr_compile to return AST Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 07/10] box: sort error codes in misc.test Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 08/10] sql: new _trigger space format with space_id Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov [this message]
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 09/10] sql: move Triggers to server Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-14 17:34 ` [tarantool-patches] Re: [PATCH v3 00/10] sql: remove " Kirill Shcherbatov
2018-06-20 8:35 ` Vladislav Shpilevoy
2018-06-28 15:47 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153b4330-dc3d-b7fc-e251-149f7257a2b5@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v3 08/10] sql: new _trigger space format with space_id' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox