Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Сергей Воронежский" <sergw@tarantool.org>
To: "Alexander Turenko" <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org,
	"Sergei Voronezhskii" <sergw@tarantool.org>,
	"Vladimir Davydov" <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2] test: disable feedback daemon test on Mac OS in CI
Date: Wed, 10 Oct 2018 10:55:21 +0300	[thread overview]
Message-ID: <1539158121.378781845@f496.i.mail.ru> (raw)
In-Reply-To: <b808a40145af7f0cd602f18cf187364ba3dccfd3.1539123300.git.alexander.turenko@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

LGTM


>Среда, 10 октября 2018, 1:17 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>The fail is known and should not have any influence on our CI results.
>
>The test should be enabled back after a fix of #3558.
>---
>
>https://github.com/tarantool/tarantool/issues/3558
>https://github.com/tarantool/tarantool/commits/Totktonada/gh-3558-disable-feedback-daemon-test-mac-os
>https://travis-ci.org/tarantool/tarantool/builds/439377915
>
> test/box-tap/feedback_daemon.skipcond | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 test/box-tap/feedback_daemon.skipcond
>
>diff --git a/test/box-tap/feedback_daemon.skipcond b/test/box-tap/feedback_daemon.skipcond
>new file mode 100644
>index 000000000..778c8a135
>--- /dev/null
>+++ b/test/box-tap/feedback_daemon.skipcond
>@@ -0,0 +1,8 @@
>+import os
>+import platform
>+
>+# Disabled on Mac OS in CI due to flaky fail #3558.
>+if os.environ.get('TRAVIS_JOB_ID', '') and platform.system() == 'Darwin':
>+    self.skip = 1
>+
>+# vim: set ft=python:
>-- 
>2.19.0
>


-- 
Сергей Воронежский

[-- Attachment #2: Type: text/html, Size: 1985 bytes --]

  reply	other threads:[~2018-10-10  7:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 18:28 [PATCH] test: disable feedback daemon test on Mac OS Alexander Turenko
2018-10-09 22:16 ` [PATCH v2] test: disable feedback daemon test on Mac OS in CI Alexander Turenko
2018-10-10  7:55   ` Сергей Воронежский [this message]
2018-10-10  8:26   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539158121.378781845@f496.i.mail.ru \
    --to=sergw@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v2] test: disable feedback daemon test on Mac OS in CI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox