[tarantool-patches] Re[2]: [tarantool-patches] [PATCH] add FindICONV and iconv wrapper

["Konstantin Belyavskiy" <k.belyavskiy@tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Georgy, thank you for the review.
Please take a look at updated patch. List of changes:
- update wrong comment
- rename file and functions iconv_wrap* to tnt_iconv*
- remove unnecessary include file

>Понедельник, 23 июля 2018, 16:17 +03:00 от Georgy Kirichenko <georgy@tarantool.org>:
>
>Mostly good, but see on my comments bellow
>
>On Friday, July 20, 2018 7:50:52 PM MSK Konstantin Belyavskiy wrote:
>> Fixing build under FreeBSD:
>> +# - Find the readline include files and libraries
>> +# - Include finding of termcap or curses
>Wrong comment
>
>> +iconv_wrap_open
>> +iconv_wrap_close
>> +iconv_wrap
>I would be like if you renamed this using pattern tnt_<name>
>>  exception_get_string
>>  exception_get_int
>> 
>>       lua/errno.c
>> +     lua/iconv_wrap.c
>I would be like if you used name like tnt_iconv.c
>>       lua/socket.c
>>       lua/pickle.c
>>       lua/fio.c
>
>> diff --git a/src/lua/iconv_wrap.h b/src/lua/iconv_wrap.h
>> new file mode 100644
>> index 000000000..03aee40e4
>> --- /dev/null
>> +++ b/src/lua/iconv_wrap.h
>I am do not really sure we need this file


Best regards,
Konstantin Belyavskiy
k.belyavskiy@tarantool.org

[-- Attachment #2: Type: text/html, Size: 1842 bytes --]