From: "Kirill Shcherbatov" <kshcherbatov@tarantool.org>
To: tarantool-patches <tarantool-patches@freelists.org>
Cc: "Nikita Pettik" <korablev@tarantool.org>,
"Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re[2]: [tarantool-patches] [PATCH v5 0/3] sql: refactor SQL Parser structures
Date: Fri, 11 May 2018 22:40:11 +0300 [thread overview]
Message-ID: <1526067611.173793802@f512.i.mail.ru> (raw)
In-Reply-To: <e8565aa1-f5e0-439c-04ad-0a1084b54c99@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
>On 11/05/2018 11:49, Kirill Shcherbatov wrote:
>> Branch: http://github.com/tarantool/tarantool/tree/gh-3272-no-sql-names
>> Issue: https://github.com/tarantool/tarantool/issues/3272
>
>Hello. Describe the changes here, and why they are needed.
Refactored SQL Column and Table structures to use space_def instead of native fields.
All temporal memory is allocated on region to prevent memory leaks and easely manage memory
with frequent insertions on SQL expression parsing.
Introduced space_def pointer in Expr instead of Table pointer.
The ResolveSelfReference function requires Table pointer to refer to, but it doesn't exist in our scenarios yet.
With correctly-initialized consistent space_def structure this would no problem.
This preliminary tasks should make able to move SQL Checks in Server code.
[-- Attachment #2: Type: text/html, Size: 1447 bytes --]
prev parent reply other threads:[~2018-05-11 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 8:49 Kirill Shcherbatov
2018-05-11 8:49 ` [tarantool-patches] [PATCH v5 1/3] sql: fix code style in sqlite3Pragma Kirill Shcherbatov
2018-05-11 20:59 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-11 8:49 ` [tarantool-patches] [PATCH v5 2/3] sql: remove SQL fields from Table and Column Kirill Shcherbatov
2018-05-11 20:59 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-14 11:20 ` Kirill Shcherbatov
2018-05-14 13:39 ` Vladislav Shpilevoy
2018-05-15 15:56 ` Kirill Shcherbatov
2018-05-11 8:49 ` [tarantool-patches] [PATCH v5 3/3] sql: space_def* instead of Table* in Expr Kirill Shcherbatov
2018-05-11 20:59 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-14 11:20 ` Kirill Shcherbatov
2018-05-11 8:58 ` [tarantool-patches] Re: [PATCH v5 0/3] sql: refactor SQL Parser structures Vladislav Shpilevoy
2018-05-11 19:40 ` Kirill Shcherbatov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526067611.173793802@f512.i.mail.ru \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] Re[2]: [tarantool-patches] [PATCH v5 0/3] sql: refactor SQL Parser structures' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox