[tarantool-patches] [tarantool-patches] Re: [PATCH] sql: Fixes op-codes' generation for skip-scan

["Ivan Koptelov" <ivan.koptelov@tarantool.org>]

[-- Attachment #1.1: Type: text/plain, Size: 963 bytes --]


>Hello. Do not start commit subject with capital letter after ‘:’.
Fixed.
>Also, I don’t see your branch at remote repository:
>you should push it before sending patch
>(in order to check Travis status, at least). 
Pushed.  https://github.com/tarantool/tarantool/tree/sb/scip-scan-fix  
>The limit for commit message is 72 chars…
>Just reminding you. 
I am confused. 72 chars is a limit for the whole commit
message? 
>Just enumerate with comma:
>Closes #xxxx, #xxxx 
Ok.
>Put here link to the branch and link to the issue 
Ok.
>Make sure that code fits into 80 chars. Now I can’t check it,
>since you haven’t pushed your branch.
I am confused again. What is this 80-chars constraint about?
>I would add to the name of test number of issue:
>gh-xxxx-skip-scan.test.lua
>
>Or, if it covers several issues, put comments before
>test cases indicating number of issue it belongs to. 
Fxd.
>Consider formatting of curly braces.
Fxd.

-- 
Ivan Koptelov

[-- Attachment #1.2: Type: text/html, Size: 6080 bytes --]

[-- Attachment #2: 0001-sql-fixes-op-codes-generation-for-skip-scan.patch --]
[-- Type: application/x-patch, Size: 5600 bytes --]