From: "Ilya Markov" <imarkov@tarantool.org>
To: "Georgy Kirichenko" <georgy@tarantool.org>
Cc: tarantool-patches <tarantool-patches@freelists.org>
Subject: [tarantool-patches] Re[2]: [tarantool-patches] Fwd: [patches] [log 2/2] say: Fix log_rotate
Date: Thu, 29 Mar 2018 14:17:59 +0300 [thread overview]
Message-ID: <1522322279.834782550@f280.i.mail.ru> (raw)
In-Reply-To: <2949639.NBXie4y127@home.lan>
>On Wednesday, March 28, 2018 11:06:10 AM MSK Ilya Markov wrote:
>> -if (log->type != SAY_LOGGER_FILE) {
>> +if (pm_atomic_load(&log->type) != SAY_LOGGER_FILE)
>> return 0;
>I am not sure you really need to use atomic. What the case you are trying to
>fix?
I use this variable as flag indicating whether it's allowed to start rotating.
I need here atomic because it is used in concurrent threads(tx thread in log_destroy and eio-worker thread in log_rotate).
--
Thank you,
Ilya Markov
prev parent reply other threads:[~2018-03-29 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 8:06 Ilya Markov
2018-03-29 8:23 ` [tarantool-patches] " Georgy Kirichenko
2018-03-29 11:17 ` Ilya Markov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522322279.834782550@f280.i.mail.ru \
--to=imarkov@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re[2]: [tarantool-patches] Fwd: [patches] [log 2/2] say: Fix log_rotate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox