* [tarantool-patches] Re[2]: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause
[not found] ` <9C7DC5C4-22A8-4F38-8E6A-FACF21115BF2@tarantool.org>
@ 2018-03-29 11:09 ` Bulat Niatshin
2018-03-29 11:28 ` [tarantool-patches] " n.pettik
0 siblings, 1 reply; 2+ messages in thread
From: Bulat Niatshin @ 2018-03-29 11:09 UTC (permalink / raw)
To: n.pettik, tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
1. You don’t need to invent own wheel: sql-tap already
has test:do_eqp_test() function.
Done.
2. Why did you divide tests and put them to different test suits?
> test/sql/gh2966-indexed-by.test.lua
> test/sql-tap/gh-2996-indexed-by.test.lua
Put them both to one file to sql-tap/ .
Done.
Branch: https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by
[-- Attachment #2: Type: text/html, Size: 2474 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tarantool-patches] Re: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause
2018-03-29 11:09 ` [tarantool-patches] Re[2]: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause Bulat Niatshin
@ 2018-03-29 11:28 ` n.pettik
0 siblings, 0 replies; 2+ messages in thread
From: n.pettik @ 2018-03-29 11:28 UTC (permalink / raw)
To: Bulat Niatshin; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Ack.
> On 29 Mar 2018, at 14:09, Bulat Niatshin <niatshin@tarantool.org> wrote:
>
> 1. You don’t need to invent own wheel: sql-tap already
> has test:do_eqp_test() function.
>
> Done.
>
>
> 2. Why did you divide tests and put them to different test suits?
> > test/sql/gh2966-indexed-by.test.lua
> > test/sql-tap/gh-2996-indexed-by.test.lua
> Put them both to one file to sql-tap/ .
>
> Done.
>
> Branch: https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by <https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by>
[-- Attachment #2: Type: text/html, Size: 3185 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-29 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180312112113.10328-1-niatshin@tarantool.org>
[not found] ` <9C7DC5C4-22A8-4F38-8E6A-FACF21115BF2@tarantool.org>
2018-03-29 11:09 ` [tarantool-patches] Re[2]: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause Bulat Niatshin
2018-03-29 11:28 ` [tarantool-patches] " n.pettik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox