[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[Alexander Turenko]

Hi, Gleb!

Please, squash your two commits into one and resend the patch.

WBR, Alexander Turenko.

On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:
> Issue from https://github.com/tarantool/tarantool/issues/2165.
> Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes.

Place it under --- mark.

> Remove support partial indexes.
> Add test which check inaccessibility of partial index syntax.
> Comment tests which use partial index, they can be uncomment when partial index will be available.

The line length exceeds 72 symbols.

> Fixed comments as per review.

That should not be part of the commit message.

> 
> Fixes #2165
> ---

Here you should place issue/branch names, changelog and other things
that should not be part of the commit.

>  src/box/sql/build.c              |  11 +-
>  src/box/sql/parse.c              | 205 +++++++++---------
>  src/box/sql/parse.y              |   2 +-
>  test/sql-tap/analyze9.test.lua   |  18 +-
>  test/sql-tap/autoindex4.test.lua |   5 +-
>  test/sql-tap/fkey1.test.lua      |   1 -
>  test/sql-tap/index6.test.lua     | 437 +++++++++++++++++++--------------------
>  test/sql-tap/suite.ini           |   1 +
>  8 files changed, 333 insertions(+), 347 deletions(-)
>
> ...
>
> diff --git a/test/sql-tap/analyze9.test.lua b/test/sql-tap/analyze9.test.lua
> index 472bad7..206ae16 100755
> --- a/test/sql-tap/analyze9.test.lua
> +++ b/test/sql-tap/analyze9.test.lua
> ...
> @@ -1177,9 +1172,9 @@ test:do_execsql_test(
>  --    [[
>  --        EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE d IS NOT NULL AND a=0 AND b=0 AND c=10;
>  --    ]], {
> ---        -- <17.6>
> +          -- <17.6>
>  --        0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX I2 (C=? AND D>?)"
> ---        -- </17.6>
> +          -- </17.6>
>  --    })
>  

Use -- *at start* of each line for the entire block or --[[ ... ]]--.
I'm about '<17.6>' lines.

> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 0bc9e83..d6ce75e 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -3,3 +3,4 @@ core = app
>  description = Database tests with #! using TAP
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> +disabled = index6.test.lua;

Space before ';' is needed according to [1]. Write a comment with the
issue re partial index enabling (#2626), please.

> -- 
> 2.7.4
> 

[tarantool-patches] Re: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[GLEB SKIBA]

[-- Attachment #1: Type: text/plain, Size: 2742 bytes --]

Hi, this is old version of my commit, which i accidentally send. I resend correct version. Is it available?


>Четверг, 29 марта 2018, 13:10 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>Hi, Gleb!
>
>Please, squash your two commits into one and resend the patch.
>
>WBR, Alexander Turenko.
>
>On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:
>> Issue from  https://github.com/tarantool/tarantool/issues/2165 .
>> Source from  https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes .
>
>Place it under --- mark.
>
>> Remove support partial indexes.
>> Add test which check inaccessibility of partial index syntax.
>> Comment tests which use partial index, they can be uncomment when partial index will be available.
>
>The line length exceeds 72 symbols.
>
>> Fixed comments as per review.
>
>That should not be part of the commit message.
>
>> 
>> Fixes #2165
>> ---
>
>Here you should place issue/branch names, changelog and other things
>that should not be part of the commit.
>
>>  src/box/sql/build.c              |  11 +-
>>  src/box/sql/parse.c              | 205 +++++++++---------
>>  src/box/sql/parse.y              |   2 +-
>>  test/sql-tap/analyze9.test.lua   |  18 +-
>>  test/sql-tap/autoindex4.test.lua |   5 +-
>>  test/sql-tap/fkey1.test.lua      |   1 -
>>  test/sql-tap/index6.test.lua     | 437 +++++++++++++++++++--------------------
>>  test/sql-tap/suite.ini           |   1 +
>>  8 files changed, 333 insertions(+), 347 deletions(-)
>>
>> ...
>>
>> diff --git a/test/sql-tap/analyze9.test.lua b/test/sql-tap/analyze9.test.lua
>> index 472bad7..206ae16 100755
>> --- a/test/sql-tap/analyze9.test.lua
>> +++ b/test/sql-tap/analyze9.test.lua
>> ...
>> @@ -1177,9 +1172,9 @@ test:do_execsql_test(
>>  --    [[
>>  --        EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE d IS NOT NULL AND a=0 AND b=0 AND c=10;
>>  --    ]], {
>> ---        -- <17.6>
>> +          -- <17.6>
>>  --        0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX I2 (C=? AND D>?)"
>> ---        -- </17.6>
>> +          -- </17.6>
>>  --    })
>> 
>
>Use -- *at start* of each line for the entire block or --[[ ... ]]--.
>I'm about '<17.6>' lines.
>
>> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
>> index 0bc9e83..d6ce75e 100644
>> --- a/test/sql-tap/suite.ini
>> +++ b/test/sql-tap/suite.ini
>> @@ -3,3 +3,4 @@ core = app
>>  description = Database tests with #! using TAP
>>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>>  is_parallel = True
>> +disabled = index6.test.lua;
>
>Space before ';' is needed according to [1]. Write a comment with the
>issue re partial index enabling (#2626), please.
>
>> -- 
>> 2.7.4
>> 
>




[-- Attachment #2: Type: text/html, Size: 3822 bytes --]

[tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[Alexander Turenko]

The branch contains two commits too.

WBR, Alexander Turenko.

On Thu, Mar 29, 2018 at 01:14:56PM +0300, GLEB SKIBA wrote:
>    Hi, this is old version of my commit, which i accidentally send. I
>    resend correct version. Is it available?
> 
>      Четверг, 29 марта 2018, 13:10 +03:00 от Alexander Turenko
>      <alexander.turenko@tarantool.org>:
> 
>    Hi, Gleb!
>    Please, squash your two commits into one and resend the patch.
>    WBR, Alexander Turenko.
>    On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:

[tarantool-patches] Re: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[GLEB SKIBA]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

I squash that two commit. Must i send new message to  tarantool-patches@freelists.org  ?


>Четверг, 29 марта 2018, 13:21 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:
>
>The branch contains two commits too.
>
>WBR, Alexander Turenko.
>
>On Thu, Mar 29, 2018 at 01:14:56PM +0300, GLEB SKIBA wrote:
>>    Hi, this is old version of my commit, which i accidentally send. I
>>    resend correct version. Is it available?
>> 
>>      Четверг, 29 марта 2018, 13:10 +03:00 от Alexander Turenko
>>      < alexander.turenko@tarantool.org >:
>> 
>>    Hi, Gleb!
>>    Please, squash your two commits into one and resend the patch.
>>    WBR, Alexander Turenko.
>>    On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:
>




[-- Attachment #2: Type: text/html, Size: 1480 bytes --]

[tarantool-patches] Re: [tarantool-patches] Re: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes

[Alexander Turenko]

Sure.

WBR, Alexander Turenko.

>Четверг, 29 марта 2018, 13:42 +03:00 от GLEB SKIBA <dmarc-noreply@freelists.org>:
>
>I squash that two commit. Must i send new message to  tarantool-patches@freelists.org  ?
>
>