Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: do not show additional generated ids
Date: Fri, 7 Jun 2019 03:38:44 +0300	[thread overview]
Message-ID: <14D3EEAF-2501-4BDC-82B6-C0BD3729C57A@tarantool.org> (raw)
In-Reply-To: <c4b453f8730f6f71b1bd5ad96407aabfecccb80e.1559149702.git.imeevma@gmail.com>



> On 29 May 2019, at 20:09, imeevma@tarantool.org wrote:
> 
> Currently, if INSERT is executed by a trigger, the new generated
> identifiers will be stored in the VDBE. This is wrong, and this
> patch fixes it.

Why is it so?

> Only identifiers generated during INSERT run by
> the user will be saved.

Firstly, I truly do not understand why this behaviour
is considered to be buggy. I don’t see discussion or
bug description.
Secondly, I do not understand what happens in this patch.
Could you please explain these changes and argue why
they are needed?

  reply	other threads:[~2019-06-07  0:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 17:09 [tarantool-patches] " imeevma
2019-06-07  0:38 ` n.pettik [this message]
2019-06-25 14:09   ` [tarantool-patches] " Imeev Mergen
2019-07-03  0:25     ` n.pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14D3EEAF-2501-4BDC-82B6-C0BD3729C57A@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: do not show additional generated ids' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox