From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member
Date: Fri, 2 Aug 2019 13:02:45 +0300 [thread overview]
Message-ID: <149DE8FA-9A0F-4853-B42C-99EF9CE9711C@tarantool.org> (raw)
In-Reply-To: <1413d8ef-6f4f-293e-a10d-56d8d90022f7@tarantool.org>
> My review fixes, on top of the branch. If you apply them, then LGTM.
> Otherwise give me your comments, and we will continue the work (it
> won't be LGTM then, *Kirill*, don't push!).
Ok, thanks, they look OK to me so I I’ve squashed them.
next prev parent reply other threads:[~2019-08-02 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 18:45 [tarantool-patches] [PATCH 0/2] Improve operability of typeof() function Nikita Pettik
2019-07-27 18:45 ` [tarantool-patches] [PATCH 1/2] sql: extend struct Mem with field_type member Nikita Pettik
2019-07-28 15:22 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-28 21:26 ` Konstantin Osipov
2019-07-31 9:14 ` n.pettik
2019-07-31 16:59 ` Vladislav Shpilevoy
2019-08-01 15:56 ` n.pettik
2019-08-01 23:11 ` Vladislav Shpilevoy
2019-08-02 10:02 ` n.pettik [this message]
2019-07-27 18:45 ` [tarantool-patches] [PATCH 2/2] sql: make default type of NULL be boolean Nikita Pettik
2019-08-02 10:52 ` [tarantool-patches] Re: [PATCH 0/2] Improve operability of typeof() function Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149DE8FA-9A0F-4853-B42C-99EF9CE9711C@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox