From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "Alexander Turenko" <alexander.turenko@tarantool.org>,
gleb-skiba@mail.ru, "Кирилл Юхин" <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes
Date: Wed, 25 Apr 2018 18:44:25 +0300 [thread overview]
Message-ID: <14828071-C85D-4C6A-A985-5372A74A9E61@tarantool.org> (raw)
In-Reply-To: <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb>
> LGTM. Nikita, can you look?
Hello. Generally speaking, patch looks OK to me as well.
I don’t like error message: it is possible to make it more
intelligible. To do it, you need to left parser as is, but in
sqlite3CreateIndex() check that ‘WHERE’ arg is empty.
On the other hand, this is temporary ban and to enable this
feature back, it is enough to revert this patch, so never mind.
next prev parent reply other threads:[~2018-04-25 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:00 [tarantool-patches] " Redacted sender "gleb-skiba" for DMARC
2018-04-25 15:17 ` [tarantool-patches] " Alexander Turenko
2018-04-25 15:44 ` n.pettik [this message]
2018-04-26 9:02 ` Kirill Yukhin
2018-04-26 12:23 ` [tarantool-patches] " GLEB SKIBA
-- strict thread matches above, loose matches on Subject: below --
2018-04-24 18:39 [tarantool-patches] " Gleb
2018-04-25 9:22 ` [tarantool-patches] " Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14828071-C85D-4C6A-A985-5372A74A9E61@tarantool.org \
--to=korablev@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gleb-skiba@mail.ru \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox