From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator
Date: Sun, 20 Jun 2021 16:50:10 +0200 [thread overview]
Message-ID: <14359465-de4b-8475-f717-a3f19a053737@tarantool.org> (raw)
In-Reply-To: <YM3ObFYl7UOYQiRo@grain>
Thanks for the fixes!
>>>>> +-- Make the master to be RAFT leader, this drops connection
>>>>> +-- to the replica2.
>>>>
>>>> 3. There was no connection to replica2 from master.
>>>>
>>>
>>> I'll update the comment, thanks! (actually replica2
>>> connected to the master initialy and this is full
>>> duplex connection which we close on reconfig, that's
>>> what I meant saying "dropping" connection, but this
>>> seems to be confusing).
>>
>> In the comment you said that this reconfig
>> drops the connection. But it still does not, even in
>> the updated definition above.
>>
>> You dropped this connection a few lines before this
>> comment.
>
> Vlad, here is an update, does it look better?
It looks better, but why did you ignore my first comment?
I remind it here:
Maybe better rename it to gh-6035-election-filter. Because otherwise
this test is not included when I run `python test-run.py election`. And I
do that quite often when make a patch which affects election only.
next prev parent reply other threads:[~2021-06-20 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:56 Cyrill Gorcunov via Tarantool-patches
2021-06-15 13:56 ` [Tarantool-patches] [PATCH v9 1/1] " Cyrill Gorcunov via Tarantool-patches
2021-06-15 14:26 ` Serge Petrenko via Tarantool-patches
2021-06-15 17:02 ` Cyrill Gorcunov via Tarantool-patches
2021-06-15 18:08 ` Cyrill Gorcunov via Tarantool-patches
2021-06-16 8:31 ` Serge Petrenko via Tarantool-patches
2021-06-16 8:43 ` Cyrill Gorcunov via Tarantool-patches
2021-06-16 8:16 ` Serge Petrenko via Tarantool-patches
2021-06-18 21:49 ` [Tarantool-patches] [PATCH v9 0/1] " Vladislav Shpilevoy via Tarantool-patches
2021-06-18 22:16 ` Cyrill Gorcunov via Tarantool-patches
2021-06-18 22:58 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-19 11:01 ` Cyrill Gorcunov via Tarantool-patches
2021-06-20 14:50 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-06-20 17:17 ` Cyrill Gorcunov via Tarantool-patches
2021-06-21 21:06 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14359465-de4b-8475-f717-a3f19a053737@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox