Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua

[Oleg Babin <olegrok@tarantool.org>]

Hi! Thanks for your patch!

I think not only "src/lua/*.lua" should be checked but also 
"src/box/lua/*.lua".

Also see one comment.

On 03/04/2020 12:39, Sergey Bronnikov wrote:
> diff --git a/src/lua/tap.lua b/src/lua/tap.lua
> index 94b080d5a..04497386e 100644
> --- a/src/lua/tap.lua
> +++ b/src/lua/tap.lua
> @@ -53,7 +53,7 @@ local function ok(test, cond, message, extra)
>       io.write(string.format("not ok - %s\n", message))
>       extra = extra or {}
>       if test.trace then
> -        local frame = debug.getinfo(3, "Sl")
> +        debug.getinfo(3, "Sl")

I think debug.getinfo() could be completely removed. It doesn't change 
any state it only returns some debug information that is completely unused.

---
Oleg Babin