From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Roman Khabibov <roman.habibov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: add CHAR description without length
Date: Mon, 3 Dec 2018 16:48:51 +0300 [thread overview]
Message-ID: <13ceb572-2260-49b0-f16a-efa8aafc0087@tarantool.org> (raw)
In-Reply-To: <20181201011251.30573-1-roman.habibov@tarantool.org>
Hi! Thanks for the patch!
Please, sending a patchset consisting from multiple
commits send a cover-letter too. Branch and Issue
links should be there.
No cover-letter is ok only for single-commit patches.
Talking about functional part - it is ok. But I've
pushed one preparation patch before your:
commit 7c0ef3cc962ce5724485b18c0da014625920bf3e
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date: Mon Dec 3 16:16:51 2018 +0300
sql: store CHAR|VARCHAR len as integer, not type_def
Please, send all the 3 commits as v2 thread to Nikita for
a second review.
prev parent reply other threads:[~2018-12-03 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 1:12 [tarantool-patches] " Roman Khabibov
2018-12-01 1:12 ` [tarantool-patches] [PATCH 2/2] sql: add test for indexed char in sub subquery Roman Khabibov
2018-12-03 13:48 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ceb572-2260-49b0-f16a-efa8aafc0087@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/2] sql: add CHAR description without length' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox