From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/6] test: support Python 3 and make quotes use consistent
Date: Thu, 10 Dec 2020 16:29:14 +0300 [thread overview]
Message-ID: <125a304a-6c1e-1f7a-6418-3156fd7e4015@tarantool.org> (raw)
In-Reply-To: <c88c56b6-7847-6247-736d-ab23338a4809@tarantool.org>
On 10.12.2020 16:23, Sergey Bronnikov via Tarantool-patches wrote:
> Hello,
>
> thanks for review
>
>
>> Hi! Thank you for the patch!
>> I regret the moment when I suggested at the same time reformat the code
>> in accordance with the PEP8) (Many changes).
>> But for tests, in my opinion it is normal. This is easy to check and
>> can't introduce degradation.
>> In addition, I think LGTM alone will be enough for such changes.
>> On 09.12.2020 18:58, Leonid Vasiliev wrote: And please remove the
>> change in quotes for "tuple" in swap.test.py, it adds too many changes.
reverted
--- a/test/replication-py/swap.test.py
+++ b/test/replication-py/swap.test.py
@@ -17,7 +17,7 @@ engines = ["memtx", "vinyl"]
def insert_tuples(_server, begin, end, msg = "tuple"):
for engine in engines:
for i in range(begin, end):
- print("box.space.{}:insert{{{}, '{} {}'}}".format(engine,
i, msg, i))
+ print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine,
i, msg, i))
print("-")
space = _server.iproto.py_con.space(engine)
print(space.insert((i, "{} {}".format(msg, i))))
<snipped>
next prev parent reply other threads:[~2020-12-10 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 7:46 [Tarantool-patches] [PATCH 0/6] Support Python 3 in tests and PEPify source code sergeyb
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 1/6] test: support Python 3 and make quotes use consistent sergeyb
2020-12-09 15:58 ` Leonid Vasiliev
2020-12-10 13:23 ` Sergey Bronnikov
2020-12-10 13:29 ` Sergey Bronnikov [this message]
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 2/6] test: remove dead code in Python tests end extra newline sergeyb
2020-12-09 20:20 ` Leonid Vasiliev
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 3/6] test: remove empty print() functions sergeyb
2020-12-09 20:27 ` Leonid Vasiliev
2020-12-10 13:26 ` Sergey Bronnikov
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 4/6] add initial flake8 config sergeyb
2020-12-09 20:57 ` Leonid Vasiliev
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 5/6] cmake: add integration with flake8 sergeyb
2020-12-07 7:46 ` [Tarantool-patches] [PATCH 6/6] ci: enable flake8 sergeyb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125a304a-6c1e-1f7a-6418-3156fd7e4015@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/6] test: support Python 3 and make quotes use consistent' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox