From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2D2C045C304
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Dec 2020 16:29:16 +0300 (MSK)
References: <cover.1607326642.git.sergeyb@tarantool.org>
 <9f4aca80dafbc8fb0ef8fb306927e78eef7fb3ef.1607326642.git.sergeyb@tarantool.org>
 <26c67b79-4f06-8bd1-7547-94e822c0a08e@tarantool.org>
 <c88c56b6-7847-6247-736d-ab23338a4809@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <125a304a-6c1e-1f7a-6418-3156fd7e4015@tarantool.org>
Date: Thu, 10 Dec 2020 16:29:14 +0300
MIME-Version: 1.0
In-Reply-To: <c88c56b6-7847-6247-736d-ab23338a4809@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 1/6] test: support Python 3 and make
 quotes use consistent
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>, tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org


On 10.12.2020 16:23, Sergey Bronnikov via Tarantool-patches wrote:
> Hello,
>
> thanks for review
>
>
>> Hi! Thank you for the patch!
>> I regret the moment when I suggested at the same time reformat the code
>> in accordance with the PEP8) (Many changes).
>> But for tests, in my opinion it is normal. This is easy to check and
>> can't introduce degradation.
>> In addition, I think LGTM alone will be enough for such changes.
>> On 09.12.2020 18:58, Leonid Vasiliev wrote: And please remove the 
>> change in quotes for "tuple" in swap.test.py, it adds too many changes. 

reverted

--- a/test/replication-py/swap.test.py
+++ b/test/replication-py/swap.test.py
@@ -17,7 +17,7 @@ engines = ["memtx", "vinyl"]
  def insert_tuples(_server, begin, end, msg = "tuple"):
      for engine in engines:
          for i in range(begin, end):
-            print("box.space.{}:insert{{{}, '{} {}'}}".format(engine, 
i, msg, i))
+            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, 
i, msg, i))
              print("-")
              space = _server.iproto.py_con.space(engine)
              print(space.insert((i, "{} {}".format(msg, i))))

<snipped>