From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Nikita Pettik <korablev@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/3] Fix CAST operation
Date: Mon, 27 May 2019 23:43:05 +0300 [thread overview]
Message-ID: <12397a47-c66a-5cbb-55f5-5457f5c767ec@tarantool.org> (raw)
In-Reply-To: <cover.1558378847.git.korablev@tarantool.org>
LGTM.
On 21/05/2019 13:34, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4229-adjust-cast
> Issue: https://github.com/tarantool/tarantool/issues/4229
>
> This patch-set allows explicit conversion using CAST operator from REAL
> to BOOLEAN and from string value containing quoted floating point
> literal to INTEGER. Detailed explanation is provided in commit messages
> and in issue description.
>
> Nikita Pettik (3):
> sql: remove redundant conversion from OP_AddImm
> sql: allow CAST operation from REAL to BOOLEAN
> sql: allow CAST operation from quoted float to int
>
> src/box/sql/vdbe.c | 2 +-
> src/box/sql/vdbemem.c | 12 ++++++++---
> test/sql/types.result | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
> test/sql/types.test.lua | 11 ++++++++++
> 4 files changed, 74 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2019-05-27 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 10:34 [tarantool-patches] " Nikita Pettik
2019-05-21 10:34 ` [tarantool-patches] [PATCH 1/3] sql: remove redundant conversion from OP_AddImm Nikita Pettik
2019-05-21 10:34 ` [tarantool-patches] [PATCH 2/3] sql: allow CAST operation from REAL to BOOLEAN Nikita Pettik
2019-05-21 10:34 ` [tarantool-patches] [PATCH 3/3] sql: allow CAST operation from quoted float to int Nikita Pettik
2019-05-27 20:43 ` Vladislav Shpilevoy [this message]
2019-05-28 1:39 ` [tarantool-patches] Re: [PATCH 0/3] Fix CAST operation Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12397a47-c66a-5cbb-55f5-5457f5c767ec@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/3] Fix CAST operation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox